Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1516)

Unified Diff: third_party/WebKit/Source/web/WebHistoryItem.cpp

Issue 2714943004: Move unique name generation and tracking into //content. (Closed)
Patch Set: Rebase again. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebFrameImplBase.h ('k') | third_party/WebKit/Source/web/WebLocalFrameImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebHistoryItem.cpp
diff --git a/third_party/WebKit/Source/web/WebHistoryItem.cpp b/third_party/WebKit/Source/web/WebHistoryItem.cpp
index 7dafe65c0362e9d925de5786ca54897371ee6d7f..6315cb904aeade6e9904ee2ad07e6a90471702b1 100644
--- a/third_party/WebKit/Source/web/WebHistoryItem.cpp
+++ b/third_party/WebKit/Source/web/WebHistoryItem.cpp
@@ -50,10 +50,12 @@ void WebHistoryItem::initialize() {
void WebHistoryItem::reset() {
m_private.reset();
+ m_target.reset();
}
void WebHistoryItem::assign(const WebHistoryItem& other) {
m_private = other.m_private;
+ m_target = other.m_target;
}
WebString WebHistoryItem::urlString() const {
@@ -78,12 +80,12 @@ void WebHistoryItem::setReferrer(const WebString& referrer,
Referrer(referrer, static_cast<ReferrerPolicy>(referrerPolicy)));
}
-WebString WebHistoryItem::target() const {
- return m_private->target();
+const WebString& WebHistoryItem::target() const {
+ return m_target;
}
void WebHistoryItem::setTarget(const WebString& target) {
- m_private->setTarget(target);
+ m_target = target;
}
WebFloatPoint WebHistoryItem::visualViewportScrollOffset() const {
« no previous file with comments | « third_party/WebKit/Source/web/WebFrameImplBase.h ('k') | third_party/WebKit/Source/web/WebLocalFrameImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698