Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: content/renderer/render_frame_impl.h

Issue 2714943004: Move unique name generation and tracking into //content. (Closed)
Patch Set: Rebase again. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/history_entry.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.h
diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h
index 361163142a2dc38f3c557b39a4049c8e3fff7fc2..3ddeaae759779d0a030ea6d32150ba0dd81ed107 100644
--- a/content/renderer/render_frame_impl.h
+++ b/content/renderer/render_frame_impl.h
@@ -44,6 +44,7 @@
#include "content/renderer/frame_blame_context.h"
#include "content/renderer/mojo/blink_interface_provider_impl.h"
#include "content/renderer/renderer_webcookiejar_impl.h"
+#include "content/renderer/unique_name_helper.h"
#include "ipc/ipc_message.h"
#include "ipc/ipc_platform_file.h"
#include "media/blink/webmediaplayer_delegate.h"
@@ -261,6 +262,9 @@ class CONTENT_EXPORT RenderFrameImpl
// Draw commands have been issued by RenderWidgetCompositor.
void DidCommitAndDrawCompositorFrame();
+ // Returns the unique name of the RenderFrame.
+ const std::string& unique_name() const { return unique_name_helper_.value(); }
+
// TODO(jam): this is a temporary getter until all the code is transitioned
// to using RenderFrame instead of RenderView.
RenderViewImpl* render_view() { return render_view_; }
@@ -507,15 +511,14 @@ class CONTENT_EXPORT RenderFrameImpl
blink::WebLocalFrame* parent,
blink::WebTreeScopeType scope,
const blink::WebString& name,
- const blink::WebString& unique_name,
+ const blink::WebString& fallback_name,
blink::WebSandboxFlags sandbox_flags,
const blink::WebFrameOwnerProperties& frame_owner_properties) override;
void didChangeOpener(blink::WebFrame* frame) override;
void frameDetached(blink::WebLocalFrame* frame, DetachType type) override;
void frameFocused() override;
void willCommitProvisionalLoad() override;
- void didChangeName(const blink::WebString& name,
- const blink::WebString& unique_name) override;
+ void didChangeName(const blink::WebString& name) override;
void didEnforceInsecureRequestPolicy(
blink::WebInsecureRequestPolicy policy) override;
void didUpdateToUniqueOrigin(
@@ -810,8 +813,7 @@ class CONTENT_EXPORT RenderFrameImpl
// Builds and sends DidCommitProvisionalLoad to the host.
void SendDidCommitProvisionalLoad(blink::WebFrame* frame,
- blink::WebHistoryCommitType commit_type,
- const blink::WebHistoryItem& item);
+ blink::WebHistoryCommitType commit_type);
// Swaps the current frame into the frame tree, replacing the
// RenderFrameProxy it is associated with. Return value indicates whether
@@ -1129,6 +1131,8 @@ class CONTENT_EXPORT RenderFrameImpl
// |frame_| has been invalidated.
bool is_main_frame_;
+ UniqueNameHelper unique_name_helper_;
+
// When a frame is detached in response to a message from the browser process,
// this RenderFrame should not be sending notifications back to it. This
// boolean is used to indicate this case.
« no previous file with comments | « content/renderer/history_entry.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698