content/renderer/history_entry.cc - Issue 2714943004: Move unique name generation and tracking into //content.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/history_entry.cc

Issue 2714943004: Move unique name generation and tracking into //content. (Closed)

Patch Set: Revert back to original check in didUpdateName Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/history_entry.cc

diff --git a/content/renderer/history_entry.cc b/content/renderer/history_entry.cc

index e74299a88f69bc19fa2d74475fe3737fd68eaa6e..90f7525b6789b514418f9dd8947b4046a999689a 100644

--- a/content/renderer/history_entry.cc

+++ b/content/renderer/history_entry.cc

@@ -174,7 +174,7 @@ HistoryEntry::HistoryNode* HistoryEntry::GetHistoryNodeForFrame(

RenderFrameImpl* frame) {

if (!frame->GetWebFrame()->parent())

return root_history_node();

- return unique_names_to_items_[frame->GetWebFrame()->uniqueName().utf8()];

+ return unique_names_to_items_[frame->unique_name()];

}

WebHistoryItem HistoryEntry::GetItemForFrame(RenderFrameImpl* frame) {