content/shell/test_runner/DEPS - Issue 2714943004: Move unique name generation and tracking into //content.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/shell/test_runner/DEPS

Issue 2714943004: Move unique name generation and tracking into //content. (Closed)

Patch Set: . Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+cc",	2 "+cc",

	3 "+content",
	dcheng 2017/03/01 23:57:26 content_shell only depends on the content public A content_shell only depends on the content public API, as it's a "canonical sample embedder". However, it seems like it should be OK for test_runner to do so, as test_runner itself is not meant to be a canonical sample like content_shell itself. Charlie Reis 2017/03/02 23:59:17 I would defer to jam@ here. Seems ok to me. Show quoted text On 2017/03/01 23:57:26, dcheng wrote: > content_shell only depends on the content public API, as it's a "canonical > sample embedder". However, it seems like it should be OK for test_runner to do > so, as test_runner itself is not meant to be a canonical sample like > content_shell itself. I would defer to jam@ here. Seems ok to me.
3 "+gin",	4 "+gin",

4 "+gpu/command_buffer/client",	5 "+gpu/command_buffer/client",

5 "+media/midi/midi_service.mojom.h",	6 "+media/midi/midi_service.mojom.h",

6 "+mojo/public",	7 "+mojo/public",

7 "+net/base",	8 "+net/base",

8 "+skia",	9 "+skia",

9 "+third_party/khronos/GLES2/gl2.h",	10 "+third_party/khronos/GLES2/gl2.h",

10 "+third_party/skia",	11 "+third_party/skia",

11 "+third_party/WebKit/public/platform",	12 "+third_party/WebKit/public/platform",

12 "+third_party/WebKit/public/web",	13 "+third_party/WebKit/public/web",

13 "+ui/display",	14 "+ui/display",

14 "+ui/events",	15 "+ui/events",

15 "+ui/gfx",	16 "+ui/gfx",

16 "+v8/include",	17 "+v8/include",

17 ]	18 ]

OLD	NEW