Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js

Issue 2714913002: DevTools: Fixes to Storage panel inconsistencies (Closed)
Patch Set: more feedback Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/resources/CookieItemsView.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js b/third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js
index 0675cb28ca7280f6c37cc0a26355262405ae67d0..95f109e73a286759acb0eb7843a75ff5a67ec3a4 100644
--- a/third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js
+++ b/third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js
@@ -66,10 +66,7 @@ Resources.DOMStorageItemsView = class extends Resources.StorageItemsView {
this.refreshItems();
}
- /**
- * @param {!Common.Event} event
- */
- _domStorageItemsCleared(event) {
+ _domStorageItemsCleared() {
if (!this.isShowing() || !this._dataGrid)
return;
@@ -207,6 +204,8 @@ Resources.DOMStorageItemsView = class extends Resources.StorageItemsView {
*/
deleteAllItems() {
this._domStorage.clear();
+ // explicitly clear the view because the event won't be fired when it has no items
+ this._domStorageItemsCleared();
}
_editingCallback(editingNode, columnIdentifier, oldText, newText) {
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/resources/CookieItemsView.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698