DevTools: Fixes to Storage panel inconsistencies

third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js

Index: third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js b/third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js
index 0675cb28ca7280f6c37cc0a26355262405ae67d0..a3038747f7919eedf588bf38d76bf6a3314485ce 100644
--- a/third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js
+++ b/third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js
@@ -67,7 +67,7 @@ Resources.DOMStorageItemsView = class extends Resources.StorageItemsView {
   }
 
   /**
-   * @param {!Common.Event} event
+   * @param {!Common.Event=} event

[eostroukhov, 2017/02/24 18:13:46]

I think you can remove the event from the parameter list.

[phulce, 2017/02/28 18:55:53]

Do you think it's better to have no documentation of the inputs when they're
unused?

[eostroukhov, 2017/02/28 20:22:51]

This function is not meant to be called with an argument.

[phulce, 2017/02/28 21:23:58]

Except it will be when invoked through event listener :) Added a comment to
explain why we also clear expliticly

[eostroukhov, 2017/02/28 21:29:05]

I don't think it matters from the API point of view. You can always pass any
number of parameters to any JS function...

    */
   _domStorageItemsCleared(event) {
     if (!this.isShowing() || !this._dataGrid)
@@ -207,6 +207,7 @@ Resources.DOMStorageItemsView = class extends Resources.StorageItemsView {
    */
   deleteAllItems() {
     this._domStorage.clear();
+    this._domStorageItemsCleared();

[eostroukhov, 2017/02/24 18:13:47]

This should be called in response to event after the storage had been cleared.
Is there anything broken?

[phulce, 2017/02/28 18:55:53]

AFAICT the target simply doesn't call the methods on the dispatcher if there
were no cookies to clear, which isn't necessarily buggy behavior IMO

   }
 
   _editingCallback(editingNode, columnIdentifier, oldText, newText) {