DevTools: Fixes to Storage panel inconsistencies

third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js

 /*
  * Copyright (C) 2008 Nokia Inc.  All rights reserved.
  * Copyright (C) 2013 Samsung Electronics. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 49 matching lines @@
           Resources.DOMStorage.Events.DOMStorageItemRemoved, this._domStorageItemRemoved, this),
       this._domStorage.addEventListener(
           Resources.DOMStorage.Events.DOMStorageItemAdded, this._domStorageItemAdded, this),
       this._domStorage.addEventListener(
           Resources.DOMStorage.Events.DOMStorageItemUpdated, this._domStorageItemUpdated, this),
     ];
     this.refreshItems();
   }
 
   /**
-   * @param {!Common.Event} event
+   * @param {!Common.Event=} event

[eostroukhov, 2017/02/24 18:13:46]

I think you can remove the event from the parameter list.

[phulce, 2017/02/28 18:55:53]

Do you think it's better to have no documentation of the inputs when they're
unused?

[eostroukhov, 2017/02/28 20:22:51]

This function is not meant to be called with an argument.

[phulce, 2017/02/28 21:23:58]

Except it will be when invoked through event listener :) Added a comment to
explain why we also clear expliticly

[eostroukhov, 2017/02/28 21:29:05]

I don't think it matters from the API point of view. You can always pass any
number of parameters to any JS function...

    */
   _domStorageItemsCleared(event) {
     if (!this.isShowing() || !this._dataGrid)
       return;
 
     this._dataGrid.rootNode().removeChildren();
     this._dataGrid.addCreationNode(false);
     this.setCanDeleteSelected(false);
   }
 
@@ skipping 119 matching lines @@
    */
   refreshItems() {
     this._domStorage.getItems((error, items) => this._showDOMStorageItems(error, items));
   }
 
   /**
    * @override
    */
   deleteAllItems() {
     this._domStorage.clear();
+    this._domStorageItemsCleared();

[eostroukhov, 2017/02/24 18:13:47]

This should be called in response to event after the storage had been cleared.
Is there anything broken?

[phulce, 2017/02/28 18:55:53]

AFAICT the target simply doesn't call the methods on the dispatcher if there
were no cookies to clear, which isn't necessarily buggy behavior IMO

   }
 
   _editingCallback(editingNode, columnIdentifier, oldText, newText) {
     var domStorage = this._domStorage;
     if (columnIdentifier === 'key') {
       if (typeof oldText === 'string')
         domStorage.removeItem(oldText);
       domStorage.setItem(newText, editingNode.data.value || '');
       this._removeDupes(editingNode);
     } else {
@@ skipping 15 matching lines @@
   }
 
   _deleteCallback(node) {
     if (!node || node.isCreationNode)
       return;
 
     if (this._domStorage)
       this._domStorage.removeItem(node.data.key);
   }
 };