DevTools: Fixes to Storage panel inconsistencies

third_party/WebKit/Source/devtools/front_end/resources/CookieItemsView.js

 /*
  * Copyright (C) 2009 Apple Inc.  All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 56 matching lines @@
     if (!this._model) {
       callback(Common.UIString('Unable to save the cookie'));
       return;
     }
     if (oldCookie && (newCookie.name() !== oldCookie.name() || newCookie.url() !== oldCookie.url()))
       this._model.deleteCookie(oldCookie);
     this._model.saveCookie(newCookie, callback);
   }
 
   /**
+   * @param {!SDK.Cookie} cookie
+   */
+  _deleteCookie(cookie) {
+    this._model.deleteCookie(cookie, () => this.refreshItems());
+  }
+
+  /**
    * @param {!Array.<!SDK.Cookie>} allCookies
    */
   _updateWithCookies(allCookies) {
     this._totalSize = allCookies.reduce((size, cookie) => size + cookie.size(), 0);
 
     if (!this._cookiesTable) {
       const parsedURL = this._cookieDomain.asParsedURL();
       const domain = parsedURL ? parsedURL.host : '';
       this._cookiesTable = new CookieTable.CookiesTable(
-          this._saveCookie.bind(this), this.refreshItems.bind(this), () => this.setCanDeleteSelected(true), domain);
+          this._saveCookie.bind(this), this.refreshItems.bind(this), () => this.setCanDeleteSelected(true),
+          this._deleteCookie.bind(this), domain);
     }
 
     var shownCookies = this.filter(allCookies, cookie => `${cookie.name()} ${cookie.value()} ${cookie.domain()}`);
     this._cookiesTable.setCookies(shownCookies);
     this._cookiesTable.show(this.element);
     this.setCanFilter(true);
     this.setCanDeleteAll(true);
     this.setCanDeleteSelected(!!this._cookiesTable.selectedCookie());
   }
 
   /**
    * @override
    */
   deleteAllItems() {
     this._model.clear(this._cookieDomain, () => this.refreshItems());
   }
 
   /**
    * @override
    */
   deleteSelectedItem() {
-    var selectedCookie = this._cookiesTable.selectedCookie();
-    if (selectedCookie)
-      this._model.deleteCookie(selectedCookie, () => this.refreshItems());
+    this._cookiesTable.removeSelectedCookie();

[eostroukhov, 2017/02/24 18:13:46]

The call ultimately gets back to this view. Maybe delete it here and then
refresh the table?

[phulce, 2017/02/28 18:55:53]

Done, sort key wasn't robust enough to handle all of the identical value cases
(domain for example) so went with neighbor preservation.

   }
 
   /**
    * @override
    */
   refreshItems() {
     this._model.getCookiesForDomain(this._cookieDomain, cookies => this._updateWithCookies(cookies));
   }
 };