Chromium Code Reviews| Index: components/ntp_snippets/remote/json_request.h |
| diff --git a/components/ntp_snippets/remote/json_request.h b/components/ntp_snippets/remote/json_request.h |
| index f498747a4a2621806d22c53f6c3ccdffa2ea5f4a..848530ef9d291b1e58a9958aeb99f41a7ed99186 100644 |
| --- a/components/ntp_snippets/remote/json_request.h |
| +++ b/components/ntp_snippets/remote/json_request.h |
| @@ -35,16 +35,14 @@ namespace internal { |
| // histograms, so do not change existing values. Insert new values at the end, |
| // and update the histogram definition. |
| enum class FetchResult { |
| - SUCCESS, |
| - DEPRECATED_EMPTY_HOSTS, |
| - URL_REQUEST_STATUS_ERROR, |
| - HTTP_ERROR, |
| - JSON_PARSE_ERROR, |
| - INVALID_SNIPPET_CONTENT_ERROR, |
| - OAUTH_TOKEN_ERROR, |
| - INTERACTIVE_QUOTA_ERROR, |
| - NON_INTERACTIVE_QUOTA_ERROR, |
| - RESULT_MAX |
| + SUCCESS = 0, |
|
Ilya Sherman
2017/02/27 19:32:26
I'd suggest keeping a comment line like
// DEPR
|
| + URL_REQUEST_STATUS_ERROR = 2, |
| + HTTP_ERROR = 3, |
| + JSON_PARSE_ERROR = 4, |
| + INVALID_SNIPPET_CONTENT_ERROR = 5, |
| + OAUTH_TOKEN_ERROR = 6, |
| + // Next available ID: 9 (due to some values being deprecated). |
| + RESULT_MAX = 9 |
| }; |
| enum FetchAPI { |