Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: components/ntp_snippets/remote/json_request.h

Issue 2714863004: [Remote suggestions] Move the throttler into the Scheduler (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/remote/json_request.h
diff --git a/components/ntp_snippets/remote/json_request.h b/components/ntp_snippets/remote/json_request.h
index f498747a4a2621806d22c53f6c3ccdffa2ea5f4a..35cae7e478dcab5c5696142c78bfe5eff5935fef 100644
--- a/components/ntp_snippets/remote/json_request.h
+++ b/components/ntp_snippets/remote/json_request.h
@@ -42,8 +42,8 @@ enum class FetchResult {
JSON_PARSE_ERROR,
INVALID_SNIPPET_CONTENT_ERROR,
OAUTH_TOKEN_ERROR,
- INTERACTIVE_QUOTA_ERROR,
- NON_INTERACTIVE_QUOTA_ERROR,
+ INTERACTIVE_QUOTA_ERROR_OBSOLETE,
tschumann 2017/02/24 10:18:08 If it's nothing widely adopted, I'd prefer prefixi
Marc Treib 2017/02/24 15:50:35 +1 to making a prefix. In fact, why not use "DEPRE
tschumann 2017/02/25 17:02:20 The numbers have the advantage that it's much easi
Marc Treib 2017/02/27 09:18:43 The MAX is there for the UMA macros, they need a "
jkrcal 2017/02/27 10:26:23 Added numeric values which allowed removing the de
+ NON_INTERACTIVE_QUOTA_ERROR_OBSOLETE,
RESULT_MAX
};

Powered by Google App Engine
This is Rietveld 408576698