Add NormalFormalParameter.covariantKeyword setter and factory parameter.

pkg/analyzer/lib/dart/ast/ast_factory.dart

Index: pkg/analyzer/lib/dart/ast/ast_factory.dart
diff --git a/pkg/analyzer/lib/dart/ast/ast_factory.dart b/pkg/analyzer/lib/dart/ast/ast_factory.dart
index 48b918d8fb72d107b8c08dc39f1a9027df84b37c..fa37989b72eb2516c167ddc96bd9da28cc8ea295 100644
--- a/pkg/analyzer/lib/dart/ast/ast_factory.dart
+++ b/pkg/analyzer/lib/dart/ast/ast_factory.dart
@@ -304,8 +304,8 @@ abstract class AstFactory {
    * Returns a documentation comment consisting of the given [tokens] and having
    * the given [references] (if supplied) embedded within it.
    */
-  Comment documentationComment(
-      List<Token> tokens, [List<CommentReference> references]);
+  Comment documentationComment(List<Token> tokens,
+      [List<CommentReference> references]);
 
   /**
    * Returns a newly created do loop.
@@ -422,6 +422,7 @@ abstract class AstFactory {
   FieldFormalParameter fieldFormalParameter(
       Comment comment,
       List<Annotation> metadata,
+      Token covariantKeyword,

[Paul Berry, 2017/02/23 22:49:20]

This is a breaking change that's going to affect code_builder.  Suggestion: move
it to the end of the argument list and make it optional.  That way code_builder
will continue to work with newer analyzers, and we can update code_builder at a
later date.

[Brian Wilkerson, 2017/02/23 22:53:45]

Is code_builder using the bleeding edge version?

       Token keyword,
       TypeAnnotation type,
       Token thisKeyword,
@@ -551,6 +552,7 @@ abstract class AstFactory {
   FunctionTypedFormalParameter functionTypedFormalParameter(
       Comment comment,
       List<Annotation> metadata,
+      Token covariantKeyword,
       TypeAnnotation returnType,
       SimpleIdentifier identifier,
       TypeParameterList typeParameters,
@@ -558,6 +560,31 @@ abstract class AstFactory {
       {Token question: null});
 
   /**
+   * Initialize a newly created generic function type.
+   */
+  GenericFunctionType genericFunctionType(
+      TypeAnnotation returnType,
+      Token functionKeyword,
+      TypeParameterList typeParameters,
+      FormalParameterList _parameters);
+
+  /**
+   * Returns a newly created generic type alias. Either or both of the
+   * [comment] and [metadata] can be `null` if the variable list does not have
+   * the corresponding attribute. The [typeParameters] can be `null` if there
+   * are no type parameters.
+   */
+  GenericTypeAlias genericTypeAlias(
+      Comment comment,
+      List<Annotation> metadata,
+      Token typedefKeyword,
+      SimpleIdentifier name,
+      TypeParameterList typeParameters,
+      Token equals,
+      GenericFunctionType functionType,
+      Token semicolon);
+
+  /**
    * Returns a newly created import show combinator.
    */
   HideCombinator hideCombinator(
@@ -848,6 +875,7 @@ abstract class AstFactory {
   SimpleFormalParameter simpleFormalParameter(
       Comment comment,
       List<Annotation> metadata,
+      Token covariantKeyword,

[Paul Berry, 2017/02/23 22:49:20]

Same issue here.

       Token keyword,
       TypeAnnotation type,
       SimpleIdentifier identifier);
@@ -883,7 +911,6 @@ abstract class AstFactory {
    * Returns a newly created super expression.
    */
   SuperExpression superExpression(Token superKeyword);
-
   /**

[Brian Wilkerson, 2017/02/23 22:46:14]

Restore blank line.

    * Returns a newly created switch case. The list of [labels] can be `null`
    * if there are no labels.
@@ -897,6 +924,7 @@ abstract class AstFactory {
    */
   SwitchDefault switchDefault(List<Label> labels, Token keyword, Token colon,
       List<Statement> statements);
+
   /**
    * Returns a newly created switch statement. The list of [members] can be
    * `null` if there are no switch members.
@@ -993,19 +1021,6 @@ abstract class AstFactory {
       List<VariableDeclaration> variables);
 
   /**
-   * Returns a newly created generic type alias. Either or both of the
-   * [comment] and [metadata] can be `null` if the variable list does not have
-   * the corresponding attribute. The [typeParameters] can be `null` if there
-   * are no type parameters.
-   */
-  GenericTypeAlias genericTypeAlias(Comment comment, List<Annotation> metadata, Token typedefKeyword, SimpleIdentifier name, TypeParameterList typeParameters, Token equals, GenericFunctionType functionType, Token semicolon);
-
-  /**
-   * Initialize a newly created generic function type.
-   */
-  GenericFunctionType genericFunctionType(TypeAnnotation returnType, Token functionKeyword, TypeParameterList typeParameters, FormalParameterList _parameters);
-
-  /**
    * Returns a newly created variable declaration statement.
    */
   VariableDeclarationStatement variableDeclarationStatement(