Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2714843002: Add NormalFormalParameter.covariantKeyword setter and factory parameter. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add NormalFormalParameter.covariantKeyword setter and factory parameter. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/57b78f422ea468c9a9775b658448bf707561b0f7

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -53 lines) Patch
M pkg/analyzer/lib/dart/ast/ast.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/dart/ast/ast_factory.dart View 8 chunks +31 lines, -16 lines 4 comments Download
M pkg/analyzer/lib/src/dart/ast/ast.dart View 5 chunks +13 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/ast_factory.dart View 4 chunks +8 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/utilities.dart View 6 chunks +6 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 5 chunks +17 lines, -24 lines 0 comments Download
M pkg/analyzer/lib/src/generated/testing/ast_test_factory.dart View 3 chunks +3 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/dart/ast/utilities_test.dart View 4 chunks +4 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
3 years, 10 months ago (2017-02-23 22:35:35 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2714843002/diff/1/pkg/analyzer/lib/dart/ast/ast_factory.dart File pkg/analyzer/lib/dart/ast/ast_factory.dart (right): https://codereview.chromium.org/2714843002/diff/1/pkg/analyzer/lib/dart/ast/ast_factory.dart#newcode914 pkg/analyzer/lib/dart/ast/ast_factory.dart:914: /** Restore blank line.
3 years, 10 months ago (2017-02-23 22:46:14 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 57b78f422ea468c9a9775b658448bf707561b0f7 (presubmit successful).
3 years, 10 months ago (2017-02-23 22:49:05 UTC) #4
Paul Berry
https://codereview.chromium.org/2714843002/diff/1/pkg/analyzer/lib/dart/ast/ast_factory.dart File pkg/analyzer/lib/dart/ast/ast_factory.dart (right): https://codereview.chromium.org/2714843002/diff/1/pkg/analyzer/lib/dart/ast/ast_factory.dart#newcode425 pkg/analyzer/lib/dart/ast/ast_factory.dart:425: Token covariantKeyword, This is a breaking change that's going ...
3 years, 10 months ago (2017-02-23 22:49:20 UTC) #5
Brian Wilkerson
3 years, 10 months ago (2017-02-23 22:53:45 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/2714843002/diff/1/pkg/analyzer/lib/dart/ast/a...
File pkg/analyzer/lib/dart/ast/ast_factory.dart (right):

https://codereview.chromium.org/2714843002/diff/1/pkg/analyzer/lib/dart/ast/a...
pkg/analyzer/lib/dart/ast/ast_factory.dart:425: Token covariantKeyword,
Is code_builder using the bleeding edge version?

Powered by Google App Engine
This is Rietveld 408576698