Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1157)

Unified Diff: third_party/WebKit/Source/devtools/front_end/common/ModuleExtensionInterfaces.js

Issue 2714833002: DevTools: use interface for ObjectUI and make it a non-autostart module (Closed)
Patch Set: fix Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/common/ModuleExtensionInterfaces.js
diff --git a/third_party/WebKit/Source/devtools/front_end/common/ModuleExtensionInterfaces.js b/third_party/WebKit/Source/devtools/front_end/common/ModuleExtensionInterfaces.js
index c49ba9369963b4bc8b2cb83b0adb6bb6e928cfa9..96f4dfb7b9f0c2c181e5d324c3a5f9acd020fc28 100644
--- a/third_party/WebKit/Source/devtools/front_end/common/ModuleExtensionInterfaces.js
+++ b/third_party/WebKit/Source/devtools/front_end/common/ModuleExtensionInterfaces.js
@@ -9,16 +9,18 @@ Common.Renderer = function() {};
Common.Renderer.prototype = {
/**
* @param {!Object} object
+ * @param {!Common.Renderer.Options=} options
dgozman 2017/04/07 21:53:50 Let's make options required parameter.
chenwilliam 2017/04/07 23:47:53 Done.
* @return {!Promise.<!Element>}
*/
- render(object) {}
+ render(object, options) {}
};
/**
* @param {!Object} object
+ * @param {!Common.Renderer.Options=} options
dgozman 2017/04/07 21:53:50 But leave it optional here.
chenwilliam 2017/04/07 23:47:53 Done.
* @return {!Promise.<!Element>}
*/
-Common.Renderer.renderPromise = function(object) {
+Common.Renderer.renderPromise = function(object, options) {
if (!object)
return Promise.reject(new Error('Can\'t render ' + object));
@@ -26,12 +28,17 @@ Common.Renderer.renderPromise = function(object) {
/**
* @param {!Common.Renderer} renderer
+ * @return {!Promise.<!Element>}
*/
function render(renderer) {
- return renderer.render(object);
+ return renderer.render(object, options);
}
};
+/** @typedef {!{title: (string|!Element|undefined), expand: (boolean|undefined),
dgozman 2017/04/07 21:53:50 expanded
chenwilliam 2017/04/07 23:47:53 Done.
+ * editable: (boolean|undefined)}} */
+Common.Renderer.Options;
+
/**
* @interface
*/

Powered by Google App Engine
This is Rietveld 408576698