Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/common/ModuleExtensionInterfaces.js

Issue 2714833002: DevTools: use interface for ObjectUI and make it a non-autostart module (Closed)
Patch Set: cl fb Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 /** 4 /**
5 * @interface 5 * @interface
6 */ 6 */
7 Common.Renderer = function() {}; 7 Common.Renderer = function() {};
8 8
9 Common.Renderer.prototype = { 9 Common.Renderer.prototype = {
10 /** 10 /**
11 * @param {!Object} object 11 * @param {!Object} object
12 * @param {!Common.Renderer.Options} options
12 * @return {!Promise.<!Element>} 13 * @return {!Promise.<!Element>}
13 */ 14 */
14 render(object) {} 15 render(object, options) {}
15 }; 16 };
16 17
17 /** 18 /**
18 * @param {!Object} object 19 * @param {!Object} object
20 * @param {!Common.Renderer.Options=} options
19 * @return {!Promise.<!Element>} 21 * @return {!Promise.<!Element>}
20 */ 22 */
21 Common.Renderer.renderPromise = function(object) { 23 Common.Renderer.renderPromise = function(object, options) {
22 if (!object) 24 if (!object)
23 return Promise.reject(new Error('Can\'t render ' + object)); 25 return Promise.reject(new Error('Can\'t render ' + object));
24 26
25 return self.runtime.extension(Common.Renderer, object).instance().then(render) ; 27 return self.runtime.extension(Common.Renderer, object).instance().then(render) ;
26 28
27 /** 29 /**
28 * @param {!Common.Renderer} renderer 30 * @param {!Common.Renderer} renderer
31 * @return {!Promise.<!Element>}
29 */ 32 */
30 function render(renderer) { 33 function render(renderer) {
31 return renderer.render(object); 34 return renderer.render(object, options || {});
32 } 35 }
33 }; 36 };
34 37
38 /** @typedef {!{title: (string|!Element|undefined), expanded: (boolean|undefined ),
39 * editable: (boolean|undefined)}} */
40 Common.Renderer.Options;
41
35 /** 42 /**
36 * @interface 43 * @interface
37 */ 44 */
38 Common.Revealer = function() {}; 45 Common.Revealer = function() {};
39 46
40 /** 47 /**
41 * @param {?Object} revealable 48 * @param {?Object} revealable
42 * @param {boolean=} omitFocus 49 * @param {boolean=} omitFocus
43 */ 50 */
44 Common.Revealer.reveal = function(revealable, omitFocus) { 51 Common.Revealer.reveal = function(revealable, omitFocus) {
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 * @interface 111 * @interface
105 */ 112 */
106 Common.QueryParamHandler = function() {}; 113 Common.QueryParamHandler = function() {};
107 114
108 Common.QueryParamHandler.prototype = { 115 Common.QueryParamHandler.prototype = {
109 /** 116 /**
110 * @param {string} value 117 * @param {string} value
111 */ 118 */
112 handleQueryParam(value) {} 119 handleQueryParam(value) {}
113 }; 120 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698