DevTools: use interface for ObjectUI and make it a non-autostart module

third_party/WebKit/Source/devtools/front_end/common/ModuleExtensionInterfaces.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 /**
  * @interface
  */
 Common.Renderer = function() {};
 
 Common.Renderer.prototype = {
   /**
    * @param {!Object} object
    * @return {!Promise.<!Element>}
    */
   render(object) {}
 };
 
 /**
  * @param {!Object} object
  * @return {!Promise.<!Element>}
  */
 Common.Renderer.renderPromise = function(object) {
   if (!object)
     return Promise.reject(new Error('Can\'t render ' + object));
 
   return self.runtime.extension(Common.Renderer, object).instance().then(render);
 
   /**
    * @param {!Common.Renderer} renderer
+   * @return {!Promise.<!Element>}
    */
   function render(renderer) {
     return renderer.render(object);
   }
 };
 
 /**
  * @interface
  */
+Common.RemoteObjectRenderer = function() {};

[pfeldman, 2017/02/25 01:30:16]

You can't say "RemoteObject" in "common", modify Renderer above instead.

[chenwilliam, 2017/04/07 20:59:27]

Done.

+
+Common.RemoteObjectRenderer.prototype = {
+  /**
+   * @param {!Object} object
+   * @param {!Common.RemoteObjectRenderer.Options=} options
+   * @return {?Element}
+   */
+  render(object, options) {}
+};
+
+/**
+ * @param {!Object} object
+ * @param {!Common.RemoteObjectRenderer.Options=} options
+ * @return {!Promise.<!Element>}
+ */
+Common.RemoteObjectRenderer.renderPromise = function(object, options) {

[dgozman, 2017/02/25 01:27:28]

Just add options to Common.Renderer? While you are here, we can migrate Revealer
to use options as well.

[chenwilliam, 2017/04/07 20:59:27]

I'll migrate Revealer in a follow-up CL.

+  var error = new Error('Can\'t render ' + object);
+  if (!object)
+    return Promise.reject(error);
+  return self.runtime.extension(Common.RemoteObjectRenderer, object).instance().then(renderer => {
+    var element = renderer.render(object, options);
+    if (!element)
+      return Promise.reject(error);
+    return element;
+  });
+};
+
+/** @typedef {!{title: (string|!Element|undefined), expand: (boolean|undefined),
+ *    editable: (boolean|undefined)}} */
+Common.RemoteObjectRenderer.Options;
+
+/**
+ * @interface
+ */
 Common.Revealer = function() {};
 
 /**
  * @param {?Object} revealable
  * @param {boolean=} omitFocus
  */
 Common.Revealer.reveal = function(revealable, omitFocus) {
   Common.Revealer.revealPromise(revealable, omitFocus);
 };
 
@@ skipping 56 matching lines @@
  * @interface
  */
 Common.QueryParamHandler = function() {};
 
 Common.QueryParamHandler.prototype = {
   /**
    * @param {string} value
    */
   handleQueryParam(value) {}
 };