Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 271483002: Split CPU and GPU DeferredCanvas tests (Closed)

Created:
6 years, 7 months ago by mtklein_C
Modified:
6 years, 7 months ago
Reviewers:
mtklein, Justin Novosad
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Split CPU and GPU DeferredCanvas tests Nothing important, just happened to notice this and figured it was good hygiene. DEF_TESTs run in parallel, while DEF_GPUTESTs run all run serially. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14603 Committed: http://code.google.com/p/skia/source/detail?r=14608

Patch Set 1 #

Patch Set 2 : if != NULL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M tests/DeferredCanvasTest.cpp View 1 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mtklein
6 years, 7 months ago (2014-05-06 17:56:17 UTC) #1
Justin Novosad
On 2014/05/06 17:56:17, mtklein wrote: lgtm
6 years, 7 months ago (2014-05-06 21:26:28 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 7 months ago (2014-05-06 21:33:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/271483002/1
6 years, 7 months ago (2014-05-06 21:34:03 UTC) #4
commit-bot: I haz the power
Change committed as 14603
6 years, 7 months ago (2014-05-06 21:43:39 UTC) #5
djsollen
A revert of this CL has been created in https://codereview.chromium.org/270283003/ by djsollen@google.com. The reason for ...
6 years, 7 months ago (2014-05-07 12:32:05 UTC) #6
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 7 months ago (2014-05-07 14:26:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/271483002/20001
6 years, 7 months ago (2014-05-07 14:27:44 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-07 14:33:59 UTC) #9
Message was sent while issue was closed.
Change committed as 14608

Powered by Google App Engine
This is Rietveld 408576698