Add an identity component for unique/opaque url::Origins.

url/origin.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "url/origin.h"
 
 #include <stdint.h>
 #include <string.h>
 
 #include "base/logging.h"
+// TODO(dcheng): Use crypto's rand util.
+#include "base/rand_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "url/gurl.h"
 #include "url/url_canon.h"
 #include "url/url_canon_stdstring.h"
 #include "url/url_constants.h"
 #include "url/url_util.h"
 
 namespace url {
 
 namespace {
 
 GURL AddSuboriginToUrl(const GURL& url, const std::string& suborigin) {
   GURL::Replacements replacements;
   if (url.scheme() == kHttpScheme) {
     replacements.SetSchemeStr(kHttpSuboriginScheme);
   } else {
     DCHECK(url.scheme() == kHttpsScheme);
     replacements.SetSchemeStr(kHttpsSuboriginScheme);
   }
   std::string new_host = suborigin + "." + url.host();
   replacements.SetHostStr(new_host);
   return url.ReplaceComponents(replacements);
 }
 
 }  // namespace
 
-Origin::Origin() : unique_(true), suborigin_(std::string()) {}
+Origin::Origin() : unique_(true) {
+  base::RandBytes(unique_origin_id_, sizeof(unique_origin_id_));
+}
 
-Origin::Origin(const GURL& url) : unique_(true), suborigin_(std::string()) {
-  if (!url.is_valid() || (!url.IsStandard() && !url.SchemeIsBlob()))
+Origin::Origin(const GURL& url) : unique_(true) {
+  if (!url.is_valid() || (!url.IsStandard() && !url.SchemeIsBlob())) {
+    base::RandBytes(unique_origin_id_, sizeof(unique_origin_id_));
     return;
+  }
 
   if (url.SchemeIsFileSystem()) {
     tuple_ = SchemeHostPort(*url.inner_url());
   } else if (url.SchemeIsBlob()) {
     // If we're dealing with a 'blob:' URL, https://url.spec.whatwg.org/#origin
     // defines the origin as the origin of the URL which results from parsing
     // the "path", which boils down to everything after the scheme. GURL's
     // 'GetContent()' gives us exactly that.
     tuple_ = SchemeHostPort(GURL(url.GetContent()));
   } else if (url.SchemeIsSuborigin()) {
@@ skipping 19 matching lines @@
     bool invalid_suborigin = no_dot || suborigin_end == 0;
     if (invalid_suborigin || tuple_.IsInvalid())
       return;
 
     suborigin_ = host.substr(0, suborigin_end);
   } else {
     tuple_ = SchemeHostPort(url);
   }
 
   unique_ = tuple_.IsInvalid();
+  if (unique_)
+    base::RandBytes(unique_origin_id_, sizeof(unique_origin_id_));
 }
 
 Origin::Origin(base::StringPiece scheme,
                base::StringPiece host,
                uint16_t port,
                base::StringPiece suborigin,
                SchemeHostPort::ConstructPolicy policy)
-    : tuple_(scheme.as_string(), host.as_string(), port, policy) {
-  unique_ = tuple_.IsInvalid();
-  suborigin_ = suborigin.as_string();
-}
+    : Origin(scheme.as_string(),
+             host.as_string(),
+             port,
+             suborigin.as_string(),
+             policy) {}
 
 Origin::Origin(std::string scheme,
                std::string host,
                uint16_t port,
                std::string suborigin,
                SchemeHostPort::ConstructPolicy policy)
     : tuple_(std::move(scheme), std::move(host), port, policy) {
   unique_ = tuple_.IsInvalid();
-  suborigin_ = std::move(suborigin);
+  if (unique_)
+    base::RandBytes(unique_origin_id_, sizeof(unique_origin_id_));
+  else
+    suborigin_ = std::move(suborigin);

[Mike West, 2017/02/24 07:58:50]

I wonder if suborigins should have an effect on the equality of opaque origins?
(+jochen@, who is now responsible for all of this ;) )

 }
 
 Origin::~Origin() {
 }
 
 // static
 Origin Origin::UnsafelyCreateOriginWithoutNormalization(
     base::StringPiece scheme,
     base::StringPiece host,
     uint16_t port) {
@@ skipping 40 matching lines @@
 
   GURL tuple_url(tuple_.GetURL());
 
   if (!suborigin_.empty())
     return AddSuboriginToUrl(tuple_url, suborigin_);
 
   return tuple_url;
 }
 
 bool Origin::IsSameOriginWith(const Origin& other) const {
-  if (unique_ || other.unique_)
-    return false;
+  if (unique_ || other.unique_) {
+    return unique_ && other.unique_
+               ? memcmp(unique_origin_id_, other.unique_origin_id_,
+                        sizeof(unique_origin_id_)) == 0
+               : false;
+  }
 
   return tuple_.Equals(other.tuple_) && suborigin_ == other.suborigin_;
 }
 
 bool Origin::IsSamePhysicalOriginWith(const Origin& other) const {
   return GetPhysicalOrigin().IsSameOriginWith(other.GetPhysicalOrigin());
 }
 
 bool Origin::DomainIs(base::StringPiece lower_ascii_domain) const {
   return !unique_ && url::DomainIs(tuple_.host(), lower_ascii_domain);
 }
 
 bool Origin::operator<(const Origin& other) const {
   return tuple_ < other.tuple_;
 }
 
 std::ostream& operator<<(std::ostream& out, const url::Origin& origin) {
   return out << origin.Serialize();
 }
 
 bool IsSameOriginWith(const GURL& a, const GURL& b) {
   return Origin(a).IsSameOriginWith(Origin(b));
 }
 
 bool IsSamePhysicalOriginWith(const GURL& a, const GURL& b) {
   return Origin(a).IsSamePhysicalOriginWith(Origin(b));
 }
 
 }  // namespace url