Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: ios/chrome/browser/ui/browser_view_controller.mm

Issue 2714813002: [iOS] Add Request Mobile Site cell to tools menu (Closed)
Patch Set: Kurt's comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/browser_view_controller.mm
diff --git a/ios/chrome/browser/ui/browser_view_controller.mm b/ios/chrome/browser/ui/browser_view_controller.mm
index 9b3b3afa3ff9a8cbe9cf40f7fc6d4b47c8adb8b0..b49bd69cbe4351e708fbc9fa503134a7d3a02507 100644
--- a/ios/chrome/browser/ui/browser_view_controller.mm
+++ b/ios/chrome/browser/ui/browser_view_controller.mm
@@ -3293,10 +3293,14 @@ - (void)showToolsMenuPopup {
[toolsPopupController setIsCurrentPageBookmarked:isBookmarked];
[toolsPopupController setCanShowFindBar:self.canShowFindBar];
[toolsPopupController setCanUseReaderMode:self.canUseReaderMode];
- [toolsPopupController
- setCanUseDesktopUserAgent:self.canUseDesktopUserAgent];
[toolsPopupController setCanShowShareMenu:self.canShowShareMenu];
+ web::UserAgentType userAgentType = [_model currentTab]
+ .webState->GetNavigationManager()
+ ->GetVisibleItem()
kkhorimoto 2017/02/27 23:44:24 It's a bug, but I believe there are some instances
liaoyuke 2017/02/28 02:01:00 Done.
+ ->GetUserAgentType();
+ [toolsPopupController setUserAgentType:userAgentType];
kkhorimoto 2017/02/27 23:44:24 Let's use dot notation since this is a property no
liaoyuke 2017/02/28 02:01:00 Done.
+
if (!IsIPadIdiom())
[toolsPopupController setIsTabLoading:_toolbarModelIOS->IsLoading()];
}

Powered by Google App Engine
This is Rietveld 408576698