Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h

Issue 2714813002: [iOS] Add Request Mobile Site cell to tools menu (Closed)
Patch Set: Update setUserAgentType implementation and Add TODO Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h
diff --git a/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h b/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h
index 1f7958319fd19e23ec2330f66a33ceb6fc098884..13e3bb3a0be0dd590dfbe3c81696f4bf7073b708 100644
--- a/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h
+++ b/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h
@@ -56,6 +56,11 @@ extern NSString* const kToolsMenuReadingListId;
@property(nonatomic, assign) id<ToolsPopupTableDelegate> delegate;
+// The user agent type used to load the current page, which also decides the
+// visibility and enability of "Request Desktop Site" and "Request Mobile Site"
Eugene But (OOO till 7-30) 2017/03/01 19:12:55 "which also decides the visibility and enability "
liaoyuke 2017/03/03 01:04:06 Acknowledged.
+// cells in the tools popup menu.
+@property(nonatomic, assign) web::UserAgentType userAgentType;
+
// Initializes the Tools popup menu.
- (void)initializeMenu:(ToolsMenuContext*)context;
@@ -86,9 +91,6 @@ extern NSString* const kToolsMenuReadingListId;
// Informs tools popup menu whether the switch to reader mode is possible.
- (void)setCanUseReaderMode:(BOOL)enabled;
-// Informs tools popup menu whether "Request Desktop Site" can be enabled.
-- (void)setCanUseDesktopUserAgent:(BOOL)value;
-
- (void)animateContentIn;
- (void)hideContent;

Powered by Google App Engine
This is Rietveld 408576698