third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc - Issue 2714803002: [LayoutNG] Allow block-flow layout to be fragmented using new approach.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc

Issue 2714803002: [LayoutNG] Allow block-flow layout to be fragmented using new approach. (Closed)

Patch Set: rebase. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc

index 880fa887edf2efa103de6c61c5be10682554f684..f6a017a6622d9fb895f291b39419ba4a3481761a 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc

@@ -364,7 +364,9 @@ TEST_F(NGLengthUtilsTest, testBorders) {

style_->setBorderLeftStyle(BorderStyleSolid);

style_->setWritingMode(WritingMode::kVerticalLr);

- NGBoxStrut borders = ComputeBorders(*style_);

+ NGConstraintSpace* constraint_space(ConstructConstraintSpace(200, 300));

+ NGBoxStrut borders = ComputeBorders(*constraint_space, *style_);

EXPECT_EQ(LayoutUnit(4), borders.block_start);

EXPECT_EQ(LayoutUnit(3), borders.inline_end);