Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(900)

Side by Side Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h

Issue 2714803002: [LayoutNG] Allow block-flow layout to be fragmented using new approach. (Closed)
Patch Set: silly me... Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NGConstraintSpaceBuilder_h 5 #ifndef NGConstraintSpaceBuilder_h
6 #define NGConstraintSpaceBuilder_h 6 #define NGConstraintSpaceBuilder_h
7 7
8 #include "core/layout/ng/ng_constraint_space.h" 8 #include "core/layout/ng/ng_constraint_space.h"
9 #include "core/layout/ng/ng_units.h" 9 #include "core/layout/ng/ng_units.h"
10 10
(...skipping 25 matching lines...) Expand all
36 36
37 NGConstraintSpaceBuilder& SetIsShrinkToFit(bool shrink_to_fit); 37 NGConstraintSpaceBuilder& SetIsShrinkToFit(bool shrink_to_fit);
38 38
39 NGConstraintSpaceBuilder& SetIsInlineDirectionTriggersScrollbar( 39 NGConstraintSpaceBuilder& SetIsInlineDirectionTriggersScrollbar(
40 bool is_inline_direction_triggers_scrollbar); 40 bool is_inline_direction_triggers_scrollbar);
41 NGConstraintSpaceBuilder& SetIsBlockDirectionTriggersScrollbar( 41 NGConstraintSpaceBuilder& SetIsBlockDirectionTriggersScrollbar(
42 bool is_block_direction_triggers_scrollbar); 42 bool is_block_direction_triggers_scrollbar);
43 43
44 NGConstraintSpaceBuilder& SetFragmentationType(NGFragmentationType); 44 NGConstraintSpaceBuilder& SetFragmentationType(NGFragmentationType);
45 NGConstraintSpaceBuilder& SetIsNewFormattingContext(bool is_new_fc); 45 NGConstraintSpaceBuilder& SetIsNewFormattingContext(bool is_new_fc);
46 NGConstraintSpaceBuilder& SetIsAnonymous(bool is_anonymous);
mstensho (USE GERRIT) 2017/02/27 13:44:36 Does it ever make sense to pass false here? I.e. c
ikilpatrick 2017/02/27 18:50:09 So the constraint space builder can be re-used for
mstensho (USE GERRIT) 2017/02/27 20:28:20 Acknowledged.
46 47
47 NGConstraintSpaceBuilder& SetMarginStrut(const NGMarginStrut& margin_strut); 48 NGConstraintSpaceBuilder& SetMarginStrut(const NGMarginStrut& margin_strut);
48 49
49 NGConstraintSpaceBuilder& SetBfcOffset(const NGLogicalOffset& offset) { 50 NGConstraintSpaceBuilder& SetBfcOffset(const NGLogicalOffset& offset) {
50 bfc_offset_ = offset; 51 bfc_offset_ = offset;
51 return *this; 52 return *this;
52 } 53 }
53 54
54 // Creates a new constraint space. This may be called multiple times, for 55 // Creates a new constraint space. This may be called multiple times, for
55 // example the constraint space will be different for a child which: 56 // example the constraint space will be different for a child which:
(...skipping 16 matching lines...) Expand all
72 LayoutUnit fragmentainer_space_available_; 73 LayoutUnit fragmentainer_space_available_;
73 74
74 unsigned parent_writing_mode_ : 2; 75 unsigned parent_writing_mode_ : 2;
75 unsigned is_fixed_size_inline_ : 1; 76 unsigned is_fixed_size_inline_ : 1;
76 unsigned is_fixed_size_block_ : 1; 77 unsigned is_fixed_size_block_ : 1;
77 unsigned is_shrink_to_fit_ : 1; 78 unsigned is_shrink_to_fit_ : 1;
78 unsigned is_inline_direction_triggers_scrollbar_ : 1; 79 unsigned is_inline_direction_triggers_scrollbar_ : 1;
79 unsigned is_block_direction_triggers_scrollbar_ : 1; 80 unsigned is_block_direction_triggers_scrollbar_ : 1;
80 unsigned fragmentation_type_ : 2; 81 unsigned fragmentation_type_ : 2;
81 unsigned is_new_fc_ : 1; 82 unsigned is_new_fc_ : 1;
83 unsigned is_anonymous_ : 1;
82 unsigned text_direction_ : 1; 84 unsigned text_direction_ : 1;
83 85
84 NGMarginStrut margin_strut_; 86 NGMarginStrut margin_strut_;
85 NGLogicalOffset bfc_offset_; 87 NGLogicalOffset bfc_offset_;
86 std::shared_ptr<NGExclusions> exclusions_; 88 std::shared_ptr<NGExclusions> exclusions_;
87 }; 89 };
88 90
89 } // namespace blink 91 } // namespace blink
90 92
91 #endif // NGConstraintSpaceBuilder 93 #endif // NGConstraintSpaceBuilder
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698