Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 27148004: Implement global load elimination based on flow engine. (Closed)

Created:
7 years, 2 months ago by titzer
Modified:
7 years, 2 months ago
Reviewers:
mvstanton
CC:
v8-dev
Visibility:
Public.

Description

Implement global load elimination based on flow engine. BUG= R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17273

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add a nested loop to the global load elimination test case. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+380 lines, -130 lines) Patch
M src/hydrogen-load-elimination.cc View 4 chunks +252 lines, -98 lines 0 comments Download
A + test/mjsunit/compiler/load-elimination-global.js View 1 3 chunks +100 lines, -10 lines 0 comments Download
A + test/mjsunit/compiler/load-elimination-osr.js View 1 chunk +28 lines, -22 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
titzer
7 years, 2 months ago (2013-10-15 08:55:46 UTC) #1
mvstanton
Hi Ben, I'd like to see another test, but looks really good. thx, --Michael https://codereview.chromium.org/27148004/diff/1/test/mjsunit/compiler/load-elimination-global.js ...
7 years, 2 months ago (2013-10-17 10:32:55 UTC) #2
titzer
On 2013/10/17 10:32:55, mvstanton wrote: > Hi Ben, > I'd like to see another test, ...
7 years, 2 months ago (2013-10-18 09:17:25 UTC) #3
mvstanton
lgtm
7 years, 2 months ago (2013-10-18 13:26:11 UTC) #4
titzer
7 years, 2 months ago (2013-10-18 14:28:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r17273 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698