third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp - Issue 2714783002: [Presentation API] (browser side) Implement reconnect() for 1-UA mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

Issue 2714783002: [Presentation API] (browser side) Implement reconnect() for 1-UA mode (Closed)

Patch Set: resolve code review comments from Derek and Mark Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media/router/presentation_service_delegate_impl.cc ('K') | « chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

diff --git a/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp b/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

index ccb119b60087002e38e4f80e5a7d1a903550d866..e0be4f16529395ac4a6fe96fe894b07b294dc5b5 100644

--- a/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

+++ b/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

@@ -441,7 +441,6 @@ void PresentationConnection::didChangeState(

switch (m_state) {

case WebPresentationConnectionState::Connecting:

- NOTREACHED();

imcheng 2017/03/16 01:42:51 Why this change?

zhaobin 2017/03/16 18:50:30 reconnect() on the same connection object will cha

return;

case WebPresentationConnectionState::Connected:

dispatchStateChangeEvent(Event::create(EventTypeNames::connect));