chrome/browser/ui/cocoa/notifications/notification_service_delegate.mm - Issue 2714743002: Retrive displayed notifications asynchronously

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/notifications/notification_service_delegate.mm

Issue 2714743002: Retrive displayed notifications asynchronously

Patch Set: apply review comments from https://codereview.chromium.org/2709213005/ Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/notifications/notification_delivery.h ('k') | content/browser/notifications/platform_notification_context_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/notifications/notification_service_delegate.mm

diff --git a/chrome/browser/ui/cocoa/notifications/notification_service_delegate.mm b/chrome/browser/ui/cocoa/notifications/notification_service_delegate.mm

index efd078525cf2d3109fc89e4982aebabea1c65bf1..c0785622f48ef1108590fca7f0804d8e72e5a012 100644

--- a/chrome/browser/ui/cocoa/notifications/notification_service_delegate.mm

+++ b/chrome/browser/ui/cocoa/notifications/notification_service_delegate.mm

@@ -38,9 +38,9 @@

newConnection.exportedInterface =

[NSXPCInterface interfaceWithProtocol:@protocol(NotificationDelivery)];

[newConnection.exportedInterface

- setClasses:[NSSet setWithObjects:[NSDictionary class], [NSImage class],

- [NSNumber class], [NSString class],

- nil]

+ setClasses:[NSSet setWithObjects:[NSArray class], [NSDictionary class],

+ [NSImage class], [NSNumber class],

+ [NSString class], nil]

forSelector:@selector(deliverNotification:)

argumentIndex:0

ofReply:NO];