Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc

Issue 2714733003: [Offline Pages] Add a timer to BackgroundLoaderOffliner to delay SavePage by 2 seconds. (Closed)
Patch Set: add additional pointer invalidation after possible navigation commit Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc
diff --git a/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc b/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc
index b526e2160c67a21ee8c2c875e8504b88050a04a5..96b8a7c4b52296230e63a93efe372df99e953147 100644
--- a/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc
+++ b/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc
@@ -368,4 +368,23 @@ TEST_F(BackgroundLoaderOfflinerTest, FailsOnErrorPage) {
EXPECT_EQ(Offliner::RequestStatus::LOADING_FAILED_NO_RETRY, request_status());
}
+TEST_F(BackgroundLoaderOfflinerTest, OnlySavesOnceOnMultipleLoads) {
+ base::Time creation_time = base::Time::Now();
+ SavePageRequest request(kRequestId, kHttpUrl, kClientId, creation_time,
+ kUserRequested);
+ EXPECT_TRUE(offliner()->LoadAndSave(request, callback()));
+ // First load
+ CompleteLoading();
+ // Second load
+ offliner()->DidStopLoading();
+ PumpLoop();
+ model()->CompleteSavingAsSuccess();
+ PumpLoop();
+
+ EXPECT_TRUE(completion_callback_called());
+ EXPECT_EQ(Offliner::RequestStatus::SAVED, request_status());
+ EXPECT_FALSE(offliner()->is_loading());
+ EXPECT_FALSE(SaveInProgress());
+}
+
} // namespace offline_pages

Powered by Google App Engine
This is Rietveld 408576698