chrome/browser/android/offline_pages/background_loader_offliner.h - Issue 2714733003: [Offline Pages] Add a timer to BackgroundLoaderOffliner to delay SavePage by 2 seconds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/background_loader_offliner.h

Issue 2714733003: [Offline Pages] Add a timer to BackgroundLoaderOffliner to delay SavePage by 2 seconds. (Closed)

Patch Set: add additional pointer invalidation after possible navigation commit Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/offline_pages/background_loader_offliner.h

diff --git a/chrome/browser/android/offline_pages/background_loader_offliner.h b/chrome/browser/android/offline_pages/background_loader_offliner.h

index f9c9002c9112a082a4c785002dafe4f6b4e0aad1..961f9c27e39166398cdac02de38627f06ffbe0dd 100644

--- a/chrome/browser/android/offline_pages/background_loader_offliner.h

+++ b/chrome/browser/android/offline_pages/background_loader_offliner.h

@@ -56,6 +56,9 @@ class BackgroundLoaderOffliner : public Offliner,

enum SaveState { NONE, SAVING, DELETE_AFTER_SAVE };

enum PageLoadState { SUCCESS, RETRIABLE, NONRETRIABLE };

+ // Called when the page is ready to be saved.

+ void SavePage();

// Called when the page has been saved.

void OnPageSaved(SavePageResult save_result, int64_t offline_id);