Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: chrome/browser/about_flags.cc

Issue 2714723002: Add feature for condensed NTP tiles. (Closed)
Patch Set: Cleanups. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/android/chrome_feature_list.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index e20393597b5297ba92c1afac8036fe02367c4541..5dd3eb11625f2f82efb92b058ad7bde833a32d47 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -585,6 +585,21 @@ const FeatureEntry::FeatureVariation kNTPSnippetsFeatureVariations[] = {
#endif // OS_ANDROID
#if defined(OS_ANDROID)
+const FeatureEntry::FeatureParam kCondensedTileLayoutForSmallScreensEnabled[] =
+ {{"condensed_tile_layout_for_small_screens_enabled", "true"}};
+
+const FeatureEntry::FeatureParam kCondensedTileLayoutForLargeScreensEnabled[] =
+ {{"condensed_tile_layout_for_large_screens_enabled", "true"}};
+
+const FeatureEntry::FeatureVariation
+ kNTPCondensedTileLayoutFeatureVariations[] = {
+ {"(small screens)", kCondensedTileLayoutForSmallScreensEnabled,
+ arraysize(kCondensedTileLayoutForSmallScreensEnabled), nullptr},
+ {"(large screens)", kCondensedTileLayoutForLargeScreensEnabled,
+ arraysize(kCondensedTileLayoutForLargeScreensEnabled), nullptr}};
+#endif // OS_ANDROID
+
+#if defined(OS_ANDROID)
const FeatureEntry::Choice kUpdateMenuItemSummaryChoices[] = {
{IDS_FLAGS_UPDATE_MENU_ITEM_NO_SUMMARY, "", ""},
{IDS_FLAGS_UPDATE_MENU_ITEM_DEFAULT_SUMMARY,
@@ -1948,6 +1963,12 @@ const FeatureEntry kFeatureEntries[] = {
{"ntp-condensed-layout", IDS_FLAGS_NTP_CONDENSED_LAYOUT_NAME,
IDS_FLAGS_NTP_CONDENSED_LAYOUT_DESCRIPTION, kOsAndroid,
FEATURE_VALUE_TYPE(chrome::android::kNTPCondensedLayoutFeature)},
+ {"ntp-condensed-tile-layout", IDS_FLAGS_NTP_CONDENSED_TILE_LAYOUT_NAME,
+ IDS_FLAGS_NTP_CONDENSED_TILE_LAYOUT_DESCRIPTION, kOsAndroid,
+ FEATURE_WITH_VARIATIONS_VALUE_TYPE(
+ chrome::android::kNTPCondensedTileLayoutFeature,
+ kNTPCondensedTileLayoutFeatureVariations,
+ ntp_snippets::kStudyName)},
{"ntp-google-g-in-omnibox", IDS_FLAGS_NTP_GOOGLE_G_IN_OMNIBOX_NAME,
IDS_FLAGS_NTP_GOOGLE_G_IN_OMNIBOX_DESCRIPTION, kOsAndroid,
FEATURE_VALUE_TYPE(chrome::android::NTPShowGoogleGInOmniboxFeature)},
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/android/chrome_feature_list.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698