Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1184)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroup.java

Issue 2714723002: Add feature for condensed NTP tiles. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroup.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroup.java b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroup.java
index af1c4a2e389543dd0d1b70f5bfcdcb57f7dc348f..fb2b875f2f7607029b3f8db827c74c900ee5b04e 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroup.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroup.java
@@ -193,9 +193,10 @@ public class TileGroup implements MostVisitedSites.Observer {
* @param tileGridLayout The layout to render the tile views into.
* @param trackLoadTasks Whether to track load tasks.
* @param titleLines The number of text lines to use for each tile title.
+ * @param condensed Whether to use a condensed layout.
*/
- public void renderTileViews(
- TileGridLayout tileGridLayout, boolean trackLoadTasks, int titleLines) {
+ public void renderTileViews(TileGridLayout tileGridLayout, boolean trackLoadTasks,
+ int titleLines, boolean condensed) {
// Map the old tile views by url so they can be reused later.
Map<String, TileView> oldTileViews = new HashMap<>();
int childCount = tileGridLayout.getChildCount();
@@ -229,7 +230,8 @@ public class TileGroup implements MostVisitedSites.Observer {
}
// No view was reused, create a new one.
- TileView tileView = buildTileView(tile, tileGridLayout, trackLoadTasks, titleLines);
+ TileView tileView =
+ buildTileView(tile, tileGridLayout, trackLoadTasks, titleLines, condensed);
tileView.setOnClickListener(new OnClickListener() {
@Override
@@ -306,13 +308,14 @@ public class TileGroup implements MostVisitedSites.Observer {
* @param parentView The parent of the new tile view.
* @param trackLoadTask Whether to track a load task.
* @param titleLines The number of text lines to use for each tile title.
+ * @param condensed Whether to use a condensed layout.
* @return The new tile view.
*/
- private TileView buildTileView(
- Tile tile, ViewGroup parentView, boolean trackLoadTask, int titleLines) {
+ private TileView buildTileView(Tile tile, ViewGroup parentView, boolean trackLoadTask,
+ int titleLines, boolean condensed) {
TileView tileView = (TileView) LayoutInflater.from(parentView.getContext())
.inflate(R.layout.tile_view, parentView, false);
- tileView.initialize(tile, titleLines);
+ tileView.initialize(tile, titleLines, condensed);
LargeIconCallback iconCallback = new LargeIconCallbackImpl(tile, trackLoadTask);
if (trackLoadTask) mObserver.onLoadTaskAdded();

Powered by Google App Engine
This is Rietveld 408576698