chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGrid.java - Issue 2714723002: Add feature for condensed NTP tiles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGrid.java

Issue 2714723002: Add feature for condensed NTP tiles. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/res/values/dimens.xml ('K') | « chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGridLayout.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileView.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGrid.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGrid.java b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGrid.java

index 90d366dddf11dc7f1f493f6795d2ec96f8e1b4b1..aa753fbbc592d6d1769c9698c0f55e1a8532303d 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGrid.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGrid.java

@@ -103,7 +103,9 @@ public class TileGrid extends OptionalLeaf implements TileGroup.Observer {

public void onBindViewHolder(TileGroup tileGroup) {

mLayout.setMaxRows(getMaxTileRows());

- tileGroup.renderTileViews(mLayout, /* trackLoadTasks = */ false, getTileTitleLines());

+ mLayout.setMaxColumns(MAX_TILE_COLUMNS);

+ tileGroup.renderTileViews(mLayout, /* trackLoadTasks = */ false, getTileTitleLines(),

+ /* condensed = */ false);

}

public void updateIconView(Tile tile) {