Chromium Code Reviews| Index: chrome/android/java/res/layout/tile_view.xml |
| diff --git a/chrome/android/java/res/layout/tile_view.xml b/chrome/android/java/res/layout/tile_view.xml |
| index f820e8f8d70af39bec875a7dd4e6c86a1162fb6c..ffe7a594e5eece0f76cc9d09e1333fcb92d41309 100644 |
| --- a/chrome/android/java/res/layout/tile_view.xml |
| +++ b/chrome/android/java/res/layout/tile_view.xml |
| @@ -12,39 +12,42 @@ |
| android:paddingStart="4dp" |
| android:paddingEnd="4dp" > |
| + <!-- The main icon. --> |
| <ImageView |
| android:id="@+id/tile_view_icon" |
| android:layout_width="@dimen/tile_view_icon_size" |
| android:layout_height="@dimen/tile_view_icon_size" |
| - android:layout_marginStart="12dp" |
| - android:layout_marginEnd="12dp" |
| - android:layout_marginTop="12dp" |
| + android:layout_gravity="center_horizontal" |
| + android:layout_marginTop="@dimen/tile_view_icon_margin_top" |
| android:contentDescription="@null" /> |
| + <!-- The offline badge. --> |
| <org.chromium.chrome.browser.widget.TintedImageView |
| android:id="@+id/offline_badge" |
| android:layout_width="@dimen/tile_view_offline_badge_size" |
| android:layout_height="@dimen/tile_view_offline_badge_size" |
| - android:layout_marginStart="48dp" |
| + android:layout_gravity="top|end" |
|
dgn
2017/02/23 15:17:44
that makes the badge move to the corner, right? wh
Michael van Ouwerkerk
2017/02/24 11:31:19
Yes, this is just a more flexible way of specifyin
|
| android:visibility="gone" |
| android:background="@drawable/offline_badge_background" |
| android:contentDescription="@string/accessibility_ntp_offline_badge" |
| chrome:tint="@color/tile_view_offline_badge_tint" |
| android:src="@drawable/offline_pin_round" /> |
| + <!-- The touch ripple. --> |
| <View |
| + android:id="@+id/tile_view_highlight" |
| android:layout_width="@dimen/tile_view_icon_size" |
| android:layout_height="@dimen/tile_view_icon_size" |
| - android:layout_marginStart="12dp" |
| - android:layout_marginEnd="12dp" |
| - android:layout_marginTop="12dp" |
| + android:layout_gravity="center_horizontal" |
| + android:layout_marginTop="@dimen/tile_view_icon_margin_top" |
| android:background="@drawable/tile_view_highlight" /> |
| + <!-- The title. --> |
| <TextView |
| android:id="@+id/tile_view_title" |
| - android:layout_width="72dp" |
| + android:layout_width="match_parent" |
| android:layout_height="wrap_content" |
| - android:layout_marginTop="66dp" |
| + android:layout_marginTop="@dimen/tile_view_title_margin_top" |
| android:ellipsize="end" |
| android:gravity="center_horizontal" |
| android:lines="2" |