Add feature for condensed NTP tiles.

chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileView.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.suggestions;
 
 import android.content.Context;
+import android.content.res.Resources;
 import android.util.AttributeSet;
 import android.view.View;
 import android.widget.FrameLayout;
 import android.widget.ImageView;
 import android.widget.TextView;
 
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.ntp.TitleUtil;
 
 /**
@@ skipping 11 matching lines @@
      */
     public TileView(Context context, AttributeSet attrs) {
         super(context, attrs);
     }
 
     /**
      * Initializes the view using the data held by {@code tile}. This should be called immediately
      * after inflation.
      * @param tile The tile that holds the data to populate this view.
      * @param titleLines The number of text lines to use for the tile title.
+     * @param condensed Whether to use a condensed layout.
      */
-    public void initialize(Tile tile, int titleLines) {
+    public void initialize(Tile tile, int titleLines, boolean condensed) {
         mTile = tile;
         TextView titleView = (TextView) findViewById(R.id.tile_view_title);
         titleView.setLines(titleLines);
         titleView.setText(TitleUtil.getTitleForDisplay(mTile.getTitle(), mTile.getUrl()));
         renderIcon();
         findViewById(R.id.offline_badge)
                 .setVisibility(mTile.isOfflineAvailable() ? View.VISIBLE : View.GONE);
+
+        if (!condensed) return;
+
+        Resources res = getResources();
+
+        setPadding(0, 0, 0, 0);

[dgn, 2017/02/23 15:17:44]

it would be nice to have a todo with a bug to move the measurements to XML once
the experiment is completed. And if that bug also specifies when the experiment
should be completed and the flags removed, so we actually get around to doing
that at some point.

[Michael van Ouwerkerk, 2017/02/24 11:31:19]

Done.

+        LayoutParams tileParams = (LayoutParams) getLayoutParams();
+        tileParams.width = res.getDimensionPixelOffset(R.dimen.tile_view_width_condensed);
+        setLayoutParams(tileParams);
+
+        View iconView = findViewById(R.id.tile_view_icon);
+        LayoutParams iconParams = (LayoutParams) iconView.getLayoutParams();
+        iconParams.setMargins(

[dgn, 2017/02/23 15:17:44]

is it only the padding that gets reset when the image changes? If the margins
are affected too it will need to be moved to renderIcon()

[Michael van Ouwerkerk, 2017/02/24 11:31:19]

I haven't seen any problems with this. Looking at the ImageView#setImageDrawable
source code and the methods it calls, it seems to only interact with padding,
not margin.

+                0, res.getDimensionPixelOffset(R.dimen.tile_view_icon_margin_top_condensed), 0, 0);
+        iconView.setLayoutParams(iconParams);
+
+        View highlightView = findViewById(R.id.tile_view_highlight);
+        LayoutParams highlightParams = (LayoutParams) highlightView.getLayoutParams();
+        highlightParams.setMargins(
+                0, res.getDimensionPixelOffset(R.dimen.tile_view_icon_margin_top_condensed), 0, 0);
+        highlightView.setLayoutParams(highlightParams);
+
+        LayoutParams titleParams = (LayoutParams) titleView.getLayoutParams();
+        titleParams.setMargins(
+                0, res.getDimensionPixelOffset(R.dimen.tile_view_title_margin_top_condensed), 0, 0);
+        titleView.setLayoutParams(titleParams);
     }
 
     /**
      * @return The tile that holds the data to populate this view.
      */
     public Tile getTile() {
         return mTile;
     }
 
     /**
      * Renders the icon held by the {@link Tile} or clears it from the view if the icon is null.
      */
     public void renderIcon() {
         ((ImageView) findViewById(R.id.tile_view_icon)).setImageDrawable(mTile.getIcon());
     }
 }