third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp - Issue 2714693002: [Presentation API] Use connection proxy to change connection state to 'closed'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

Issue 2714693002: [Presentation API] Use connection proxy to change connection state to 'closed' (Closed)

Patch Set: fix unittest errors Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/presentation/presentation_dispatcher_unittest.cc ('k') | third_party/WebKit/Source/modules/presentation/PresentationReceiverTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

diff --git a/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp b/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

index a2b2034ecffc69b55bd380c9206d0ed2dd64f9a2..4f4bb2d51ae4fe267ca2f1ec9110299d10d62dbb 100644

--- a/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

+++ b/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

@@ -162,8 +162,6 @@ PresentationConnection::~PresentationConnection() {

void PresentationConnection::bindProxy(

std::unique_ptr<WebPresentationConnectionProxy> proxy) {

DCHECK(proxy);

- // TODO(zhaobin): Restore to DCHECK(!m_proxy) when reconnect() is properly

- // implemented.

m_proxy = std::move(proxy);

}

@@ -401,7 +399,7 @@ void PresentationConnection::close() {

}

WebPresentationClient* client = presentationClient(getExecutionContext());

if (client)

- client->closeSession(m_url, m_id);

+ client->closeSession(m_url, m_id, m_proxy.get());

tearDown();

}