Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

Issue 2714693002: [Presentation API] Use connection proxy to change connection state to 'closed' (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp
diff --git a/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp b/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp
index 8de73c9597708d1eab3610dcf2aebe3f174800d2..b6f1391467e6a29e960c640dbba4f498b2293b13 100644
--- a/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp
+++ b/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp
@@ -163,8 +163,6 @@ PresentationConnection::~PresentationConnection() {
void PresentationConnection::bindProxy(
std::unique_ptr<WebPresentationConnectionProxy> proxy) {
DCHECK(proxy);
- // TODO(zhaobin): Restore to DCHECK(!m_proxy) when reconnect() is properly
- // implemented.
m_proxy = std::move(proxy);
}
@@ -402,7 +400,7 @@ void PresentationConnection::close() {
}
WebPresentationClient* client = presentationClient(getExecutionContext());
if (client)
- client->closeSession(m_url, m_id);
+ client->closeSession(m_url, m_id, m_proxy.get());
tearDown();
}

Powered by Google App Engine
This is Rietveld 408576698