[SPv2] Implement effect compositing for indirect reasons

third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PaintArtifactCompositor_h
 #define PaintArtifactCompositor_h
 
 #include "base/memory/ref_counted.h"
 #include "platform/PlatformExport.h"
 #include "platform/RuntimeEnabledFeatures.h"
@@ skipping 74 matching lines @@
   std::unique_ptr<JSONObject> layersAsJSON(LayerTreeFlags) const;
 
 #ifndef NDEBUG
   void showDebugData();
 #endif
 
  private:
   // A pending layer is a collection of paint chunks that will end up in
   // the same cc::Layer.
   struct PLATFORM_EXPORT PendingLayer {
-    PendingLayer(const PaintChunk& firstPaintChunk);
-    void add(const PaintChunk&, GeometryMapper*);
+    PendingLayer(const PaintChunk& firstPaintChunk,
+                 bool chunkIsForeign,
+                 GeometryMapper&);
+    void merge(const PendingLayer&, GeometryMapper&);
+    void upcast(const PropertyTreeState&, GeometryMapper&);

[chrishtr, 2017/02/28 22:50:35]

Document these methods.

[trchen, 2017/03/01 01:26:11]

Acknowledged.

[trchen, 2017/03/07 01:41:24]

Done.

     FloatRect bounds;
     Vector<const PaintChunk*> paintChunks;
     bool knownToBeOpaque;
     bool backfaceHidden;
     PropertyTreeState propertyTreeState;
+    bool isForeign;
   };
 
   PaintArtifactCompositor();
 
   class ContentLayerClientImpl;
 
   // Collects the PaintChunks into groups which will end up in the same
   // cc layer. This includes testing PaintChunks for "merge" compatibility (e.g.
   // directly composited property tree states are separately composited)
   // and overlap testing (PaintChunks that overlap existing PaintLayers they
@@ skipping 23 matching lines @@
       const PaintChunk&,
       const PaintArtifact&);
 
   // This method is an implementation of Algorithm step 4 from goo.gl/6xP8Oe.
   static scoped_refptr<cc::DisplayItemList> recordPendingLayer(
       const PaintArtifact&,
       const PendingLayer&,
       const gfx::Rect& combinedBounds,
       GeometryMapper&);
 
-  static bool canMergeInto(const PaintArtifact&,
-                           const PaintChunk& newChunk,
-                           const PendingLayer& candidatePendingLayer);
-
-  // Returns true if |newChunk| might overlap |candidatePendingLayer| in the
-  // root property tree space. If it does overlap, it will always return true.
-  // If it doesn't overlap, it might return true in cases were we can't
-  // efficiently determine a false value, or the truth depends on
-  // compositor animations.
-  static bool mightOverlap(const PaintChunk& newChunk,
-                           const PendingLayer& candidatePendingLayer,
-                           GeometryMapper&);
+  static void layerizeGroup(const PaintArtifact&,

[chrishtr, 2017/02/28 22:50:35]

Document this method.

[trchen, 2017/03/01 01:26:11]

Acknowledged.

[trchen, 2017/03/07 01:41:24]

Done.

+                            Vector<PendingLayer>& pendingLayers,
+                            GeometryMapper&,
+                            const EffectPaintPropertyNode&,
+                            Vector<PaintChunk>::const_iterator& chunkCursor);
 
   scoped_refptr<cc::Layer> m_rootLayer;
   std::unique_ptr<WebLayer> m_webLayer;
   Vector<std::unique_ptr<ContentLayerClientImpl>> m_contentLayerClients;
 
   bool m_extraDataForTestingEnabled = false;
   std::unique_ptr<ExtraDataForTesting> m_extraDataForTesting;
   friend class StubChromeClientForSPv2;
 
   bool m_isTrackingRasterInvalidations;
@@ skipping 36 matching lines @@
                            PendingLayer);
   FRIEND_TEST_ALL_PREFIXES(PaintArtifactCompositorTestWithPropertyTrees,
                            PendingLayerWithGeometry);
   FRIEND_TEST_ALL_PREFIXES(PaintArtifactCompositorTestWithPropertyTrees,
                            PendingLayerKnownOpaque);
 };
 
 }  // namespace blink
 
 #endif  // PaintArtifactCompositor_h