Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: chrome/browser/android/webapk/webapk_info.h

Issue 2714633003: Adds more metadata to the about:webapks page (Closed)
Patch Set: Adds more metadata to the about:webapks page Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/shortcut_helper.cc ('k') | chrome/browser/android/webapk/webapk_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/webapk/webapk_info.h
diff --git a/chrome/browser/android/webapk/webapk_info.h b/chrome/browser/android/webapk/webapk_info.h
index 746c5f517f29d43679cc5c8c80e05e74a7bafae8..be0edae472741b8bf986c85ed84ab588ae487e0e 100644
--- a/chrome/browser/android/webapk/webapk_info.h
+++ b/chrome/browser/android/webapk/webapk_info.h
@@ -8,6 +8,8 @@
#include <string>
#include "base/macros.h"
+#include "content/public/common/manifest.h"
+#include "third_party/WebKit/public/platform/modules/screen_orientation/WebScreenOrientationLockType.h"
// Structure with information about a WebAPK.
//
@@ -16,14 +18,26 @@
// move-constructs its string arguments (which are copied from Java to C++ into
// a temporary prior to construction).
struct WebApkInfo {
- WebApkInfo(std::string short_name,
+ WebApkInfo(std::string name,
+ std::string short_name,
std::string package_name,
int shell_apk_version,
- int version_code);
+ int version_code,
+ std::string uri,
+ std::string scope,
+ std::string manifest_url,
+ std::string manifest_start_url,
+ blink::WebDisplayMode display,
+ blink::WebScreenOrientationLockType orientation,
+ int64_t theme_color,
+ int64_t background_color);
~WebApkInfo();
- WebApkInfo& operator=(WebApkInfo&& other) = default;
- WebApkInfo(WebApkInfo&& other) = default;
+ WebApkInfo& operator=(WebApkInfo&& other);
+ WebApkInfo(WebApkInfo&& other);
+
+ // Short name of the WebAPK.
+ std::string name;
// Short name of the WebAPK.
std::string short_name;
@@ -37,6 +51,15 @@ struct WebApkInfo {
// Version code of the WebAPK.
int version_code;
+ std::string uri;
+ std::string scope;
+ std::string manifest_url;
+ std::string manifest_start_url;
+ blink::WebDisplayMode display;
+ blink::WebScreenOrientationLockType orientation;
+ int64_t theme_color;
+ int64_t background_color;
+
private:
DISALLOW_COPY_AND_ASSIGN(WebApkInfo);
};
« no previous file with comments | « chrome/browser/android/shortcut_helper.cc ('k') | chrome/browser/android/webapk/webapk_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698