Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java

Issue 2714633003: Adds more metadata to the about:webapks page (Closed)
Patch Set: Adds more metadata to the about:webapks page Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/shortcut_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
index 769b9300a1828491f7a983e3c9a7f995ae95f074..b494a36b1328a08783fcec5b90a59799fd3e4b06 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
@@ -671,10 +671,19 @@ public class ShortcutHelper {
*/
@CalledByNative
public static void retrieveWebApks(long callbackPointer) {
+ List<String> names = new ArrayList<>();
List<String> shortNames = new ArrayList<>();
List<String> packageNames = new ArrayList<>();
List<Integer> shellApkVersions = new ArrayList<>();
List<Integer> versionCodes = new ArrayList<>();
+ List<String> uris = new ArrayList<>();
+ List<String> scopes = new ArrayList<>();
+ List<String> manifestUrls = new ArrayList<>();
+ List<String> manifestStartUrls = new ArrayList<>();
+ List<Integer> displayModes = new ArrayList<>();
+ List<Integer> orientations = new ArrayList<>();
+ List<Long> themeColors = new ArrayList<>();
+ List<Long> backgroundColors = new ArrayList<>();
Context context = ContextUtils.getApplicationContext();
PackageManager packageManager = context.getPackageManager();
@@ -685,16 +694,29 @@ public class ShortcutHelper {
WebApkInfo webApkInfo =
WebApkInfo.create(packageInfo.packageName, "", ShortcutSource.UNKNOWN);
if (webApkInfo != null) {
+ names.add(webApkInfo.name());
shortNames.add(webApkInfo.shortName());
packageNames.add(webApkInfo.webApkPackageName());
shellApkVersions.add(webApkInfo.shellApkVersion());
versionCodes.add(packageInfo.versionCode);
+ uris.add(webApkInfo.uri().toString());
+ scopes.add(webApkInfo.scopeUri().toString());
+ manifestUrls.add(webApkInfo.manifestUrl());
+ manifestStartUrls.add(webApkInfo.manifestStartUrl());
+ displayModes.add(webApkInfo.displayMode());
+ orientations.add(webApkInfo.orientation());
+ themeColors.add(webApkInfo.themeColor());
+ backgroundColors.add(webApkInfo.backgroundColor());
}
}
}
- nativeOnWebApksRetrieved(callbackPointer, shortNames.toArray(new String[0]),
- packageNames.toArray(new String[0]), integerListToIntArray(shellApkVersions),
- integerListToIntArray(versionCodes));
+ nativeOnWebApksRetrieved(callbackPointer, names.toArray(new String[0]),
+ shortNames.toArray(new String[0]), packageNames.toArray(new String[0]),
+ integerListToIntArray(shellApkVersions), integerListToIntArray(versionCodes),
+ uris.toArray(new String[0]), scopes.toArray(new String[0]),
+ manifestUrls.toArray(new String[0]), manifestStartUrls.toArray(new String[0]),
+ integerListToIntArray(displayModes), integerListToIntArray(orientations),
+ longListToLongArray(themeColors), longListToLongArray(backgroundColors));
}
private static int[] integerListToIntArray(@NonNull List<Integer> list) {
@@ -705,7 +727,17 @@ public class ShortcutHelper {
return array;
}
+ private static long[] longListToLongArray(@NonNull List<Long> list) {
+ long[] array = new long[list.size()];
+ for (int i = 0; i < list.size(); i++) {
+ array[i] = list.get(i);
+ }
+ return array;
+ }
+
private static native void nativeOnWebappDataStored(long callbackPointer);
- private static native void nativeOnWebApksRetrieved(long callbackPointer, String[] shortNames,
- String[] packageName, int[] shellApkVersions, int[] versionCodes);
+ private static native void nativeOnWebApksRetrieved(long callbackPointer, String[] names,
+ String[] shortNames, String[] packageName, int[] shellApkVersions, int[] versionCodes,
+ String[] uris, String[] scopes, String[] manifestUrls, String[] manifestStartUrls,
+ int[] displayModes, int[] orientations, long[] themeColors, long[] backgroundColors);
}
« no previous file with comments | « no previous file | chrome/browser/android/shortcut_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698