Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: ui/gfx/color_utils.h

Issue 2714633003: Adds more metadata to the about:webapks page (Closed)
Patch Set: Adds more metadata to the about:webapks page Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/webapks_handler.cc ('k') | ui/gfx/color_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/color_utils.h
diff --git a/ui/gfx/color_utils.h b/ui/gfx/color_utils.h
index f6ba46aa85f7f36b29e4bfc4dc51b0707eaf9897..429eb7d86ffcd28ed5019d4a6e87e32957e8339a 100644
--- a/ui/gfx/color_utils.h
+++ b/ui/gfx/color_utils.h
@@ -5,6 +5,8 @@
#ifndef UI_GFX_COLOR_UTILS_H_
#define UI_GFX_COLOR_UTILS_H_
+#include <string>
+
#include "third_party/skia/include/core/SkColor.h"
#include "ui/gfx/gfx_export.h"
@@ -138,6 +140,13 @@ GFX_EXPORT bool IsInvertedColorScheme();
// surface.
GFX_EXPORT SkColor DeriveDefaultIconColor(SkColor text_color);
+// Creates an rgba string for an SkColor.
msw 2017/02/28 18:17:10 nit: describe the output format or give an example
gonzalon 2017/02/28 22:30:27 Done.
+GFX_EXPORT std::string SkColorToRGBAString(SkColor color);
msw 2017/02/28 18:17:10 Please add unit tests for these functions.
gonzalon 2017/02/28 22:30:27 Done.
+
+// Creates an rgb string for an SkColor, but leaves the alpha blank so that
+// the css can fill it in.
msw 2017/02/28 18:17:10 Remove the mention about css, it's not really rele
gonzalon 2017/02/28 22:30:27 Done.
+GFX_EXPORT std::string SkColorToRGBComponents(SkColor color);
msw 2017/02/28 18:17:10 nit: s/Components/String/ to match above.
gonzalon 2017/02/28 22:30:27 Done.
+
} // namespace color_utils
#endif // UI_GFX_COLOR_UTILS_H_
« no previous file with comments | « chrome/browser/ui/webui/webapks_handler.cc ('k') | ui/gfx/color_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698