Adds more metadata to the about:webapks page

chrome/browser/resources/webapks/about_webapks.js

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @typedef {{
+ *   name: string,
  *   shortName: string,
  *   packageName: string,
  *   shellApkVersion: number,
  *   versionCode: number
+ *   uri: string,
+ *   scope: string,
+ *   manifestUrl: string,
+ *   manifestStartUrl: string,
+ *   displayMode: string,
+ *   orientation: string,
+ *   themeColor: string,
+ *   backgroundColor: string,
  * }}
  */
 var WebApkInfo;
 
 /**
  * Creates and returns an element (with |text| as content) assigning it the
  * |className| class.
  *
  * @param {string} text Text to be shown in the span.

[Dan Beam, 2017/02/28 17:40:52]

you need to add a @param for type

[gonzalon, 2017/02/28 17:56:50]

Done.

  * @param {string} className Class to be assigned to the new element.
  * @return {Element} The created element.
  */
-function createSpanWithTextAndClass(text, className) {
-  var element = createElementWithClassName('span', className);
+function createElementWithTextAndClass(text, type, className) {
+  var element = createElementWithClassName(type, className);
   element.textContent = text;
   return element;
 }
 
 /**
  * Callback from the backend with the information of a WebAPK to display.
  * This will be called once for each WebAPK available on the device and each
  * one will be appended at the end of the other.
  *
  * @param {!Array<WebApkInfo>} webApkList List of objects with information about
  * WebAPKs installed.
  */
 function returnWebApksInfo(webApkList) {
   for (let webApkInfo of webApkList) {
     addWebApk(webApkInfo);
   }
 }
 
 /**
+ * @param {!Array<Element>} webApkList List of elements which contain WebAPK
+ * attributes.
+ * @param {string} label Text that identifies the new element.
+ * @param {string} value Text to set in the new element.
+ */
+function addWebApkField(webApkList, label, value) {
+  divElement = createElementWithTextAndClass(
+    label, 'div', 'app-property-label');

[Dan Beam, 2017/02/28 17:40:52]

this indent is slightly off, maybe run `git cl format --js`?

[gonzalon, 2017/02/28 17:56:50]

I didn't know the '--js' option existed, I was wondering why the js files
weren't being formatted, thanks a lot!

+  divElement.appendChild(
+    createElementWithTextAndClass(value, 'span', 'app-property-value'));
+  webApkList.appendChild(divElement);
+}
+
+/**
  * Adds a new entry to the page with the information of a WebAPK.
  *
  * @param {WebApkInfo} webApkInfo Information about an installed WebAPK.
  */
 function addWebApk(webApkInfo) {
   var webApkList = $('webapk-list');
 
   webApkList.appendChild(
-      createSpanWithTextAndClass(webApkInfo.shortName, 'app-name'));
+      createElementWithTextAndClass(webApkInfo.name, 'span', 'app-name'));
 
-  webApkList.appendChild(
-      createSpanWithTextAndClass('Package name: ', 'app-property-label'));
-  webApkList.appendChild(document.createTextNode(webApkInfo.packageName));
+  webApkList.appendChild(createElementWithTextAndClass(
+    'Short name: ', 'span', 'app-property-label'));
+  webApkList.appendChild(document.createTextNode(webApkInfo.shortName));
 
-  webApkList.appendChild(document.createElement('br'));
-  webApkList.appendChild(createSpanWithTextAndClass(
-      'Shell APK version: ', 'app-property-label'));
-  webApkList.appendChild(document.createTextNode(webApkInfo.shellApkVersion));
-
-  webApkList.appendChild(document.createElement('br'));
-  webApkList.appendChild(
-      createSpanWithTextAndClass('Version code: ', 'app-property-label'));
-  webApkList.appendChild(document.createTextNode(webApkInfo.versionCode));
+  addWebApkField(webApkList, 'Package name: ', webApkInfo.packageName);
+  addWebApkField(webApkList, 'Shell APK version: ', webApkInfo.shellApkVersion);
+  addWebApkField(webApkList, 'Version code: ', webApkInfo.versionCode);
+  addWebApkField(webApkList, 'URI: ', webApkInfo.uri);
+  addWebApkField(webApkList, 'Scope: ', webApkInfo.scope);
+  addWebApkField(webApkList, 'Manifest URL: ', webApkInfo.manifestUrl);
+  addWebApkField(webApkList,
+    'Manifest Start URL: ', webApkInfo.manifestStartUrl);
+  addWebApkField(webApkList, 'Display Mode: ', webApkInfo.displayMode);
+  addWebApkField(webApkList, 'Orientation: ', webApkInfo.orientation);
+  addWebApkField(webApkList, 'Theme color: ', webApkInfo.themeColor);
+  addWebApkField(webApkList, 'Background color: ', webApkInfo.backgroundColor);
 }
 
 document.addEventListener('DOMContentLoaded', function() {
   chrome.send('requestWebApksInfo');
 });