Adds more metadata to the about:webapks page

chrome/browser/android/webapk/webapk_installer.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/webapk/webapk_installer.h"
 
 #include "base/android/build_info.h"
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/android/path_utils.h"
@@ skipping 15 matching lines @@
 #include "chrome/common/chrome_switches.h"
 #include "components/version_info/version_info.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/common/manifest_util.h"
 #include "jni/WebApkInstaller_jni.h"
 #include "net/base/load_flags.h"
 #include "net/http/http_status_code.h"
 #include "net/traffic_annotation/network_traffic_annotation.h"
 #include "net/url_request/url_fetcher.h"
 #include "ui/gfx/codec/png_codec.h"
+#include "ui/gfx/color_utils.h"
 #include "url/gurl.h"
 
 namespace {
 
 // The default WebAPK server URL.
 const char kDefaultServerUrl[] =
     "https://webapk.googleapis.com/v1/webApks/"
     "?alt=proto&key=AIzaSyAoI6v-F31-3t9NunLYEiKcPIqgTJIUZBw";
 
 // The MIME type of the POST data sent to the server.
@@ skipping 25 matching lines @@
 GURL GetScope(const ShortcutInfo& info) {
   return (info.scope.is_valid()) ? info.scope
                                  : ShortcutHelper::GetScopeFromURL(info.url);
 }
 
 // Converts a color from the format specified in content::Manifest to a CSS
 // string.
 std::string ColorToString(int64_t color) {
   if (color == content::Manifest::kInvalidOrMissingColor)
     return "";
-
-  SkColor sk_color = reinterpret_cast<uint32_t&>(color);

[pkotwicz, 2017/02/27 23:39:39]

Nit: Please keep this line and call color_utils::SkColorToRGBAString() on a
separate line

[gonzalon, 2017/02/28 14:59:32]

Done, but it would be nice if reviews were consistent regarding this. I actually
agree with putting the variable on a new line like you said, but I got reviews
saying to inline it because it was 'cleaner'. Is there a guideline regarding
this or is it a matter of preference according to the reviewer? I've seen many
examples across the codebase using both styles.

-  int r = SkColorGetR(sk_color);
-  int g = SkColorGetG(sk_color);
-  int b = SkColorGetB(sk_color);
-  double a = SkColorGetA(sk_color) / 255.0;
-  return base::StringPrintf("rgba(%d,%d,%d,%.2f)", r, g, b, a);
+  return color_utils::SkColorToRGBAString(reinterpret_cast<uint32_t&>(color));
 }
 
 // Get Chrome's current ABI. It depends on whether Chrome is running as a 32 bit
 // app or 64 bit, and the device's cpu architecture as well. Note: please keep
 // this function stay in sync with |chromium_android_linker::GetCpuAbi()|.
 std::string getCurrentAbi() {
 #if defined(__arm__) && defined(__ARM_ARCH_7A__)
   return "armeabi-v7a";
 #elif defined(__arm__)
   return "armeabi";
@@ skipping 530 matching lines @@
 
 void WebApkInstaller::OnSuccess() {
   finish_callback_.Run(true, webapk_package_);
   delete this;
 }
 
 void WebApkInstaller::OnFailure() {
   finish_callback_.Run(false, webapk_package_);
   delete this;
 }