Adds more metadata to the about:webapks page

chrome/browser/ui/webui/color_utils.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_WEBUI_COLOR_UTILS_H_
+#define CHROME_BROWSER_UI_WEBUI_COLOR_UTILS_H_
+
+#include <string>
+
+#include "base/macros.h"
+#include "third_party/skia/include/core/SkColor.h"
+

[pkotwicz, 2017/02/27 20:50:59]

Nit: ui/gfx/color_utils.h is probably a better home for these functions

[gonzalon, 2017/02/27 21:33:17]

Done.

+class ColorUtils {
+ public:
+  // Creates an rgba string for an SkColor.
+  static std::string SkColorToRGBAString(SkColor color);
+
+  // Creates an rgba string for a color represented as an int64.
+  static std::string ColorToString(int64_t color);

[pkotwicz, 2017/02/27 20:50:59]

I think that this method should remain an implementation detail of
webapks_handler.cc. However, it is good that ColorToString() uses
SkColorToRGBAString() (and that we are sharing SkColorToRGBAString() across
several places in Chrome)

[gonzalon, 2017/02/27 21:33:17]

It was mostly a convenience function to avoid having to call SkColorToRGBAString
with a static_cast, but since I moved it to the gfx file I don't want to bloat
it with many very similar functions, so I just added SkColorToRGBAString and
added the cast in the places that it's called.

+
+  // Creates an rgb string for an SkColor, but leaves the alpha blank so that
+  // the css can fill it in.
+  static std::string SkColorToRGBComponents(SkColor color);
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(ColorUtils);
+};
+
+#endif  // CHROME_BROWSER_UI_WEBUI_COLOR_UTILS_H_