Adds more metadata to the about:webapks page

chrome/browser/android/shortcut_helper.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/shortcut_helper.h"
 
 #include <jni.h>
 #include <utility>
 
 #include "base/android/jni_android.h"
@@ skipping 302 matching lines @@
   DCHECK(jsplash_image_callback);
   base::Closure* splash_image_callback =
       reinterpret_cast<base::Closure*>(jsplash_image_callback);
   splash_image_callback->Run();
   delete splash_image_callback;
 }
 
 void OnWebApksRetrieved(JNIEnv* env,
                         const JavaParamRef<jclass>& clazz,
                         const jlong jcallback_pointer,
+                        const JavaParamRef<jobjectArray>& jnames,
                         const JavaParamRef<jobjectArray>& jshort_names,
                         const JavaParamRef<jobjectArray>& jpackage_names,
                         const JavaParamRef<jintArray>& jshell_apk_versions,
-                        const JavaParamRef<jintArray>& jversion_codes) {
+                        const JavaParamRef<jintArray>& jversion_codes,
+                        const JavaParamRef<jobjectArray>& juris,
+                        const JavaParamRef<jobjectArray>& jscopes,
+                        const JavaParamRef<jobjectArray>& jmanifest_urls,
+                        const JavaParamRef<jobjectArray>& jmanifest_start_urls,
+                        const JavaParamRef<jintArray>& jdisplay_modes,
+                        const JavaParamRef<jintArray>& jorientations,
+                        const JavaParamRef<jlongArray>& jtheme_colors,
+                        const JavaParamRef<jlongArray>& jbackground_colors) {
   DCHECK(jcallback_pointer);
+  std::vector<std::string> names;
+  base::android::AppendJavaStringArrayToStringVector(env, jnames, &names);
   std::vector<std::string> short_names;
   base::android::AppendJavaStringArrayToStringVector(env, jshort_names,
                                                      &short_names);
   std::vector<std::string> package_names;
   base::android::AppendJavaStringArrayToStringVector(env, jpackage_names,
                                                      &package_names);
   std::vector<int> shell_apk_versions;
   base::android::JavaIntArrayToIntVector(env, jshell_apk_versions,
                                          &shell_apk_versions);
   std::vector<int> version_codes;
   base::android::JavaIntArrayToIntVector(env, jversion_codes, &version_codes);
+  std::vector<std::string> uris;
+  base::android::AppendJavaStringArrayToStringVector(env, juris, &uris);
+  std::vector<std::string> scopes;
+  base::android::AppendJavaStringArrayToStringVector(env, jscopes, &scopes);
+  std::vector<std::string> manifest_urls;
+  base::android::AppendJavaStringArrayToStringVector(env, jmanifest_urls,
+                                                     &manifest_urls);
+  std::vector<std::string> manifest_start_urls;
+  base::android::AppendJavaStringArrayToStringVector(env, jmanifest_start_urls,
+                                                     &manifest_start_urls);
+  std::vector<int> display_modes;
+  base::android::JavaIntArrayToIntVector(env, jdisplay_modes, &display_modes);
+  std::vector<int> orientations;
+  base::android::JavaIntArrayToIntVector(env, jorientations, &orientations);
+  std::vector<int64_t> theme_colors;
+  base::android::JavaLongArrayToInt64Vector(env, jtheme_colors, &theme_colors);
+  std::vector<int64_t> background_colors;
+  base::android::JavaLongArrayToInt64Vector(env, jbackground_colors,
+                                            &background_colors);
 
+  DCHECK(short_names.size() == names.size());
   DCHECK(short_names.size() == package_names.size());
   DCHECK(short_names.size() == shell_apk_versions.size());
   DCHECK(short_names.size() == version_codes.size());
+  DCHECK(short_names.size() == uris.size());
+  DCHECK(short_names.size() == scopes.size());
+  DCHECK(short_names.size() == manifest_urls.size());
+  DCHECK(short_names.size() == manifest_start_urls.size());
+  DCHECK(short_names.size() == display_modes.size());
+  DCHECK(short_names.size() == orientations.size());
+  DCHECK(short_names.size() == theme_colors.size());
+  DCHECK(short_names.size() == background_colors.size());

[pkotwicz, 2017/02/27 20:50:58]

I don't think that the DCHECKs are useful. If the DCHECKs fail you will just
crash in the for loop.
My vote is for removing the DCHECKS

 
   std::vector<WebApkInfo> webapk_list;
   webapk_list.reserve(short_names.size());
   for (size_t i = 0; i < short_names.size(); ++i) {
-    webapk_list.push_back(WebApkInfo(std::move(short_names[i]),
-                                     std::move(package_names[i]),
-                                     shell_apk_versions[i], version_codes[i]));
+    webapk_list.push_back(WebApkInfo(
+        std::move(names[i]), std::move(short_names[i]),
+        std::move(package_names[i]), shell_apk_versions[i], version_codes[i],
+        std::move(uris[i]), std::move(scopes[i]), std::move(manifest_urls[i]),
+        std::move(manifest_start_urls[i]),
+        static_cast<blink::WebDisplayMode>(std::move(display_modes[i])),
+        static_cast<blink::WebScreenOrientationLockType>(
+            std::move(orientations[i])),
+        std::move(theme_colors[i]), std::move(background_colors[i])));
   }
 
   ShortcutHelper::WebApkInfoCallback* webapk_list_callback =
       reinterpret_cast<ShortcutHelper::WebApkInfoCallback*>(jcallback_pointer);
   webapk_list_callback->Run(webapk_list);
   delete webapk_list_callback;
 }
 
 bool ShortcutHelper::RegisterShortcutHelper(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }