chrome/browser/permissions/permission_uma_util.h - Issue 2714603002: Make PermissionManager use ContentSettingsType internally more

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_uma_util.h

Issue 2714603002: Make PermissionManager use ContentSettingsType internally more (Closed)

Patch Set: address comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/permissions/permission_uma_util.h

diff --git a/chrome/browser/permissions/permission_uma_util.h b/chrome/browser/permissions/permission_uma_util.h

index f1efe4cfa5cf9116900c0fe929200567fbda7951..6a4de41138ea822c4d3d34a8a02fc0a414bc5ce3 100644

--- a/chrome/browser/permissions/permission_uma_util.h

+++ b/chrome/browser/permissions/permission_uma_util.h

@@ -106,12 +106,6 @@ class PermissionUmaUtil {

static const char kPermissionsPromptIgnoredPriorDismissCountPrefix[];

static const char kPermissionsPromptIgnoredPriorIgnoreCountPrefix[];

- // TODO(timloh): Remove this content::PermissionType overload when we add MIDI

- // to ContentSettingsType.

- static void PermissionRequested(content::PermissionType permission,

- const GURL& requesting_origin,

- const GURL& embedding_origin,

- Profile* profile);

static void PermissionRequested(ContentSettingsType permission,

const GURL& requesting_origin,

const GURL& embedding_origin,