Clean Obsolete HTTP Data from the Password Store

components/password_manager/core/browser/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//third_party/protobuf/proto_library.gni")
 
 if (is_android) {
   import("//build/config/android/config.gni")
 }
 
@@ skipping 34 matching lines @@
     "export/password_exporter.h",
     "facet_manager.cc",
     "facet_manager.h",
     "facet_manager_host.h",
     "form_fetcher.h",
     "form_fetcher_impl.cc",
     "form_fetcher_impl.h",
     "form_saver.h",
     "form_saver_impl.cc",
     "form_saver_impl.h",
+    "hsts_query.cc",
+    "hsts_query.h",
+    "http_data_cleaner.cc",
+    "http_data_cleaner.h",
     "http_password_store_migrator.cc",
     "http_password_store_migrator.h",
     "import/csv_reader.cc",
     "import/csv_reader.h",
     "import/password_csv_reader.cc",
     "import/password_csv_reader.h",
     "import/password_importer.cc",
     "import/password_importer.h",
     "keychain_migration_status_mac.h",
     "log_manager.cc",
     "log_manager.h",
     "log_receiver.h",
     "log_router.cc",
     "log_router.h",
     "login_database.cc",
     "login_database.h",
     "login_database_ios.cc",
     "login_database_mac.cc",
     "login_database_posix.cc",
     "login_database_win.cc",
     "login_model.cc",
     "login_model.h",
-    "obsolete_http_cleaner.cc",
-    "obsolete_http_cleaner.h",
     "password_autofill_manager.cc",
     "password_autofill_manager.h",
     "password_bubble_experiment.cc",
     "password_bubble_experiment.h",
     "password_form_manager.cc",
     "password_form_manager.h",
     "password_generation_manager.cc",
     "password_generation_manager.h",
     "password_manager.cc",
     "password_manager.h",
@@ skipping 71 matching lines @@
     "//google_apis",
     "//net",
     "//sql",
     "//third_party/protobuf:protobuf_lite",
     "//third_party/re2",
     "//ui/base",
     "//ui/gfx",
     "//url",
   ]
 
+  if (is_ios) {
+    sources -= [

[vasilii, 2017/03/28 17:27:44]

What about if (!is_ios) sources += ?

[jdoerrie, 2017/03/29 11:27:56]

Done.

+      "hsts_query.cc",
+      "hsts_query.h",
+      "http_data_cleaner.cc",
+      "http_data_cleaner.h",
+    ]
+  }
+
   if (is_mac || is_ios) {
     sources -= [ "login_database_posix.cc" ]
   }
 
   if (!is_ios) {
     deps += [ "//components/safe_browsing/password_protection" ]
   }
 
   # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
   configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
@@ skipping 36 matching lines @@
   ]
 
   public_deps = [
     ":browser",
     "//testing/gmock",
     "//url:url",
   ]
   deps = [
     "//base",
     "//components/autofill/core/common",
+    "//net:net",
     "//testing/gtest",
   ]
 }
 
 bundle_data("unit_tests_bundle_data") {
   visibility = [ ":unit_tests" ]
   testonly = true
   sources = [
     "//components/test/data/password_manager/login_db_v1.sql",
     "//components/test/data/password_manager/login_db_v10.sql",
@@ skipping 37 matching lines @@
     "affiliation_utils_unittest.cc",
     "browser_save_password_progress_logger_unittest.cc",
     "credential_manager_logger_unittest.cc",
     "credential_manager_password_form_manager_unittest.cc",
     "export/csv_writer_unittest.cc",
     "export/password_csv_writer_unittest.cc",
     "export/password_exporter_unittest.cc",
     "facet_manager_unittest.cc",
     "form_fetcher_impl_unittest.cc",
     "form_saver_impl_unittest.cc",
+    "hsts_query_unittest.cc",
+    "http_data_cleaner_unittest.cc",
     "http_password_store_migrator_unittest.cc",
     "import/csv_reader_unittest.cc",
     "import/password_csv_reader_unittest.cc",
     "import/password_importer_unittest.cc",
     "log_manager_unittest.cc",
     "log_router_unittest.cc",
     "login_database_unittest.cc",
     "login_model_unittest.cc",
-    "obsolete_http_cleaner_unittest.cc",
     "password_autofill_manager_unittest.cc",
     "password_bubble_experiment_unittest.cc",
     "password_form_manager_unittest.cc",
     "password_generation_manager_unittest.cc",
     "password_manager_settings_migration_experiment_unittest.cc",
     "password_manager_unittest.cc",
     "password_manager_util_unittest.cc",
     "password_reuse_detection_manager_unittest.cc",
     "password_reuse_detector_unittest.cc",
     "password_store_default_unittest.cc",
     "password_store_origin_unittest.h",
     "password_store_unittest.cc",
     "password_syncable_service_unittest.cc",
     "password_ui_utils_unittest.cc",
     "psl_matching_helper_unittest.cc",
     "sql_table_builder_unittest.cc",
     "statistics_table_unittest.cc",
   ]
   if (is_mac) {
     sources -= [ "password_store_default_unittest.cc" ]
   }
   if (is_ios) {
     sources += [ "login_database_ios_unittest.cc" ]
+    sources -= [
+      "hsts_query_unittest.cc",
+      "http_data_cleaner_unittest.cc",
+    ]
   }
   deps = [
     ":test_support",
     ":unit_tests_bundle_data",
     "//base/test:test_support",
     "//components/autofill/core/browser:test_support",
     "//components/autofill/core/browser/proto",
     "//components/autofill/core/common",
     "//components/os_crypt:test_support",
     "//components/password_manager/core/browser:proto",
     "//components/password_manager/core/common",
     "//components/prefs:test_support",
     "//components/security_state/core",
     "//components/strings",
     "//components/sync:test_support_driver",
     "//components/sync:test_support_model",
     "//components/variations",
     "//net:test_support",
     "//sql:test_support",
     "//testing/gmock",
     "//testing/gtest",
     "//ui/base",
     "//url",
   ]
 }