Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: pkg/analyzer/lib/src/dart/analysis/driver.dart

Issue 2714523002: Update UnitElementResult signature. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/dart/analysis/driver.dart
diff --git a/pkg/analyzer/lib/src/dart/analysis/driver.dart b/pkg/analyzer/lib/src/dart/analysis/driver.dart
index d1504d478572f65a38b1914122b3a0ad3114cd30..c0854ccafea3cfe8622819837ed84897ade815c9 100644
--- a/pkg/analyzer/lib/src/dart/analysis/driver.dart
+++ b/pkg/analyzer/lib/src/dart/analysis/driver.dart
@@ -631,9 +631,9 @@ class AnalysisDriver {
* [UnitElementResult] for the file with the given [path], or with `null` if
* the file cannot be analyzed.
*
- * The signature is based on the content of the file, and the transitive
- * closure of files imported and exported by the the library of the requested
- * file.
+ * The signature is based the APIs of the files of the library (including
+ * the file itself) of the requested file and the transitive closure of files
+ * imported and exported by the the library.
*/
Future<String> getUnitElementSignature(String path) {
if (!_fileTracker.fsState.hasUri(path)) {
@@ -820,7 +820,7 @@ class AnalysisDriver {
try {
CompilationUnitElement element =
libraryContext.computeUnitElement(library.source, file.source);
- String signature = _getResolvedUnitSignature(library, file);
+ String signature = library.transitiveSignature;
return new UnitElementResult(path, file.contentHash, signature, element);
} finally {
libraryContext.dispose();
@@ -830,7 +830,7 @@ class AnalysisDriver {
String _computeUnitElementSignature(String path) {
FileState file = _fileTracker.fsState.getFileForPath(path);
FileState library = file.library ?? file;
- return _getResolvedUnitSignature(library, file);
+ return library.transitiveSignature;
}
/**
@@ -1705,9 +1705,9 @@ class UnitElementResult {
final String contentHash;
/**
- * The signature of the [element] based on the content of the file, and the
- * transitive closure of files imported and exported by the the library of
- * the requested file.
+ * The signature of the [element] is based the APIs of the files of the
+ * library (including the file itself) of the requested file and the
+ * transitive closure of files imported and exported by the the library.
*/
final String signature;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698