Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2714523002: Update UnitElementResult signature. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update UnitElementResult signature. It should depend only on API signatures, and should not include the content of the file. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/41224bcf5095d29b6afcc70b12480ed0d70892b0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 10 months ago (2017-02-22 16:44:00 UTC) #1
Brian Wilkerson
lgtm
3 years, 10 months ago (2017-02-22 16:56:03 UTC) #2
scheglov
3 years, 10 months ago (2017-02-22 17:03:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
41224bcf5095d29b6afcc70b12480ed0d70892b0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698