Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: chrome/browser/chromeos/settings/session_manager_operation_unittest.cc

Issue 2714493002: Load DeviceLocalAccount policy and DeviceSettings immediately on restore after Chrome crash. (Closed)
Patch Set: reduce duplication and avoid double load start Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/settings/session_manager_operation_unittest.cc
diff --git a/chrome/browser/chromeos/settings/session_manager_operation_unittest.cc b/chrome/browser/chromeos/settings/session_manager_operation_unittest.cc
index 5aa0afdfec84bfba03ff5bf1b8e3fde4b47dab92..13cd4884ab0ad01a38d103bf57eab442437316d5 100644
--- a/chrome/browser/chromeos/settings/session_manager_operation_unittest.cc
+++ b/chrome/browser/chromeos/settings/session_manager_operation_unittest.cc
@@ -108,6 +108,7 @@ class SessionManagerOperationTest : public testing::Test {
TEST_F(SessionManagerOperationTest, LoadNoPolicyNoKey) {
LoadSettingsOperation op(
false /* force_key_load */, true /* cloud_validations */,
+ false /* force_immediate_load */,
base::Bind(&SessionManagerOperationTest::OnOperationCompleted,
base::Unretained(this)));
@@ -128,6 +129,7 @@ TEST_F(SessionManagerOperationTest, LoadOwnerKey) {
owner_key_util_->SetPublicKeyFromPrivateKey(*policy_.GetSigningKey());
LoadSettingsOperation op(
false /* force_key_load */, true /* cloud_validations */,
+ false /* force_immediate_load */,
base::Bind(&SessionManagerOperationTest::OnOperationCompleted,
base::Unretained(this)));
@@ -146,6 +148,30 @@ TEST_F(SessionManagerOperationTest, LoadPolicy) {
device_settings_test_helper_.set_policy_blob(policy_.GetBlob());
LoadSettingsOperation op(
false /* force_key_load */, true /* cloud_validations */,
+ false /* force_immediate_load */,
+ base::Bind(&SessionManagerOperationTest::OnOperationCompleted,
+ base::Unretained(this)));
+
+ EXPECT_CALL(*this,
+ OnOperationCompleted(&op, DeviceSettingsService::STORE_SUCCESS));
+ op.Start(&device_settings_test_helper_, owner_key_util_, NULL);
+ device_settings_test_helper_.Flush();
+ Mock::VerifyAndClearExpectations(this);
+
+ ASSERT_TRUE(op.policy_data().get());
+ EXPECT_EQ(policy_.policy_data().SerializeAsString(),
+ op.policy_data()->SerializeAsString());
+ ASSERT_TRUE(op.device_settings().get());
+ EXPECT_EQ(policy_.payload().SerializeAsString(),
+ op.device_settings()->SerializeAsString());
+}
+
+TEST_F(SessionManagerOperationTest, LoadImmediately) {
+ owner_key_util_->SetPublicKeyFromPrivateKey(*policy_.GetSigningKey());
+ device_settings_test_helper_.set_policy_blob(policy_.GetBlob());
+ LoadSettingsOperation op(
+ false /* force_key_load */, true /* cloud_validations */,
+ true /* force_immediate_load */,
base::Bind(&SessionManagerOperationTest::OnOperationCompleted,
base::Unretained(this)));
@@ -169,6 +195,7 @@ TEST_F(SessionManagerOperationTest, RestartLoad) {
device_settings_test_helper_.set_policy_blob(policy_.GetBlob());
LoadSettingsOperation op(
false /* force_key_load */, true /* cloud_validations */,
+ false /* force_immediate_load */,
base::Bind(&SessionManagerOperationTest::OnOperationCompleted,
base::Unretained(this)));

Powered by Google App Engine
This is Rietveld 408576698