cros: Fix restoring session windows after crash inconsistent minimized window counts

chrome/browser/sessions/session_restore_browsertest_chromeos.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "chrome/browser/sessions/session_restore.h"
+
 #include <stddef.h>
 
 #include <list>
 #include <vector>
 
 #include "base/command_line.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/defaults.h"
 #include "chrome/browser/prefs/session_startup_pref.h"
@@ skipping 56 matching lines @@
     return Browser::CreateParams::CreateForApp(name, trusted, gfx::Rect(),
                                                profile(), true);
   }
 
   // Turn on session restore before we restart.
   void TurnOnSessionRestore() {
     SessionStartupPref::SetStartupPref(
         browser()->profile(), SessionStartupPref(SessionStartupPref::LAST));
   }
 
-  Profile* profile() { return browser()->profile(); }
+  Profile* profile() {
+    if (!profile_)
+      profile_ = browser()->profile();
 
+    return profile_;
+  }
+
+ private:
   std::list<Browser*> browser_list_;
+  Profile* profile_ = nullptr;
 };
 
 // Thse tests are in pairs. The PRE_ test creates some browser windows and
 // the following test confirms that the correct windows are restored after a
 // restart.
 
 IN_PROC_BROWSER_TEST_F(SessionRestoreTestChromeOS, PRE_RestoreBrowserWindows) {
   // One browser window is always created by default.
   EXPECT_TRUE(browser());
   // Create a second normal browser window.
@@ skipping 102 matching lines @@
     ++total_count;
     if (browser->window()->IsMinimized())
       ++minimized_count;
   }
   EXPECT_EQ(2u, total_count);
   // Chrome OS always activates the last browser window on login, which results
   // in one window being restored. This seems reasonable as it reminds users
   // they have a browser running instead of just showing them an empty desktop.
   EXPECT_EQ(1u, minimized_count);
 }
+
+// Tests that restoring session windows after crash should keep consistent
+// minimized window counts (crbug.com/694854).
+IN_PROC_BROWSER_TEST_F(SessionRestoreTestChromeOS,
+                       PRE_RestoreSessionWindowsAfterCrash) {
+  // One browser window is always created by default.
+  ASSERT_TRUE(browser());
+  browser()->window()->Minimize();
+
+  Browser* browser2 =
+      CreateBrowserWithParams(Browser::CreateParams(profile(), true));
+  browser2->window()->Minimize();
+
+  Browser* browser3 =
+      CreateBrowserWithParams(Browser::CreateParams(profile(), true));
+  browser3->window()->Minimize();
+
+  EXPECT_TRUE(browser()->window()->IsMinimized());
+  EXPECT_TRUE(browser2->window()->IsMinimized());
+  EXPECT_TRUE(browser3->window()->IsMinimized());
+
+  // Do not turn on startup session restore.
+}
+
+IN_PROC_BROWSER_TEST_F(SessionRestoreTestChromeOS,
+                       RestoreSessionWindowsAfterCrash) {
+  // By default, there will be one browser window opened.
+  ASSERT_EQ(1u, BrowserList::GetInstance()->size());
+  Browser* default_browser = BrowserList::GetInstance()->GetLastActive();
+
+  content::WindowedNotificationObserver close_observer(
+      chrome::NOTIFICATION_BROWSER_CLOSED,
+      content::Source<Browser>(default_browser));
+  // |default_browser| will be closed before session restore of last session.
+  SessionRestore::RestoreSessionAfterCrash(default_browser);
+  close_observer.Wait();
+
+  size_t total_count = 0;
+  size_t minimized_count = 0;
+  for (auto* browser : *BrowserList::GetInstance()) {
+    ++total_count;
+    if (browser->window()->IsMinimized())
+      ++minimized_count;
+  }
+  EXPECT_EQ(3u, total_count);
+  EXPECT_EQ(2u, minimized_count);
+}