Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: net/quic/quic_unacked_packet_map.h

Issue 271443008: Minor QUIC cleanup to combine QuicUnackedPacketMap's RemovePacket and (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sending for review Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_sent_packet_manager.cc ('k') | net/quic/quic_unacked_packet_map.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_unacked_packet_map.h
diff --git a/net/quic/quic_unacked_packet_map.h b/net/quic/quic_unacked_packet_map.h
index eab4f363464d38317933032459341fd8166f3f6e..011760a4807c6dd809899f8849c2252db00985dd 100644
--- a/net/quic/quic_unacked_packet_map.h
+++ b/net/quic/quic_unacked_packet_map.h
@@ -120,14 +120,10 @@ class NET_EXPORT_PRIVATE QuicUnackedPacketMap {
// Returns true if there are any pending crypto packets.
bool HasPendingCryptoPackets() const;
- // Removes entries from the unacked packet map, and deletes
- // the retransmittable frames associated with the packet.
+ // Deletes the retransmittable frames associated with the packet and removes
+ // it from unacked packets if it's not pending.
// Does not remove any previous or subsequent transmissions of this packet.
- void RemovePacket(QuicPacketSequenceNumber sequence_number);
-
- // Neuters the specified packet. Deletes any retransmittable
- // frames, and sets all_transmissions to only include itself.
- void NeuterPacket(QuicPacketSequenceNumber sequence_number);
+ void NeuterIfPendingOrRemovePacket(QuicPacketSequenceNumber sequence_number);
// Returns true if the packet has been marked as sent by SetSent.
static bool IsSentAndNotPending(const TransmissionInfo& transmission_info);
« no previous file with comments | « net/quic/quic_sent_packet_manager.cc ('k') | net/quic/quic_unacked_packet_map.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698