Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 271443006: Fix crash and off-by-one error in MMX YUVA->ARGB conversion. (Closed)

Created:
6 years, 7 months ago by rileya (GONE FROM CHROMIUM)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@yuv_tables
Visibility:
Public.

Description

Fix crash and off-by-one error in MMX YUVA->ARGB conversion. BUG=370520 TEST=YUVConvertTest.YUVAtoARGB_MMX_MatchReference Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269428

Patch Set 1 : #

Patch Set 2 : Add unit test #

Patch Set 3 : Actually add test data file. #

Patch Set 4 : Remove test file #

Patch Set 5 : Fix preexisting off-by-one in YUVA conversion asm. #

Patch Set 6 : Make off-by-one fix 32-bit-friendly, fix Android unused stuff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -2 lines) Patch
M media/base/simd/convert_yuva_to_argb_mmx.inc View 1 2 3 4 5 3 chunks +24 lines, -2 lines 0 comments Download
M media/base/yuv_convert_unittest.cc View 1 2 3 4 5 3 chunks +53 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
rileya (GONE FROM CHROMIUM)
Turns out there was no test coverage at all for software YUVA->ARGB conversion! Fixed the ...
6 years, 7 months ago (2014-05-06 20:41:55 UTC) #1
rileya (GONE FROM CHROMIUM)
On 2014/05/06 20:41:55, rileya wrote: > Turns out there was no test coverage at all ...
6 years, 7 months ago (2014-05-06 20:56:12 UTC) #2
scherkus (not reviewing)
lgtm
6 years, 7 months ago (2014-05-06 21:00:18 UTC) #3
rileya1
Since git cl upload refuses to upload the test 'bali_640x360_P420_alpha.yuv' file, is dcommitting that file ...
6 years, 7 months ago (2014-05-06 21:48:15 UTC) #4
DaleCurtis
Feel free to dcommit it separately.
6 years, 7 months ago (2014-05-06 21:50:05 UTC) #5
rileya (GONE FROM CHROMIUM)
The unit test uncovered a preexisting off-by-one bug in the YUVA convert assembly. I couldn't ...
6 years, 7 months ago (2014-05-08 19:25:57 UTC) #6
scherkus (not reviewing)
lgtm
6 years, 7 months ago (2014-05-08 20:38:21 UTC) #7
rileya (GONE FROM CHROMIUM)
The CQ bit was checked by rileya@chromium.org
6 years, 7 months ago (2014-05-08 21:01:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rileya@chromium.org/271443006/100001
6 years, 7 months ago (2014-05-08 21:07:41 UTC) #9
rileya (GONE FROM CHROMIUM)
The CQ bit was checked by rileya@chromium.org
6 years, 7 months ago (2014-05-08 22:46:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rileya@chromium.org/271443006/110001
6 years, 7 months ago (2014-05-08 22:47:52 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-09 22:02:35 UTC) #12
Message was sent while issue was closed. 
Change committed as 269428

Powered by Google App Engine
This is Rietveld 408576698