Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Issue 271443004: Oilpan: fix gc_tracing compilation after r173313. (Closed)

Created:
6 years, 7 months ago by sof
Modified:
6 years, 7 months ago
CC:
blink-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Oilpan: fix gc_tracing compilation after r173313. Expand the GCInfos for ListHashSet<> and ListHashSetNode<> to include the required class name string when compiling with GC_TRACING enabled. R=ager@chromium.org,haraken@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173396

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M Source/platform/heap/Heap.h View 2 chunks +15 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sof
Please take a look.
6 years, 7 months ago (2014-05-06 14:51:19 UTC) #1
Mads Ager (chromium)
LGTM
6 years, 7 months ago (2014-05-06 14:53:34 UTC) #2
haraken
LGTM
6 years, 7 months ago (2014-05-06 14:53:59 UTC) #3
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 7 months ago (2014-05-06 14:55:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/271443004/1
6 years, 7 months ago (2014-05-06 14:56:00 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-06 15:59:14 UTC) #6
Message was sent while issue was closed.
Change committed as 173396

Powered by Google App Engine
This is Rietveld 408576698